Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor OpenTelemetry] Update Configuration Documentation to Include Log/Span Processors and Use SpanProcessors in Default Config #28597

Merged

Conversation

JacksonWeber
Copy link
Member

@JacksonWeber JacksonWeber commented Feb 16, 2024

Packages impacted by this PR

@monitor-opentelemetry

Describe the problem that is addressed by this PR

README should account for all configuration options.
We should not rely on the deprecated SpanProcessor field on the SDK config.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@JacksonWeber JacksonWeber changed the title [Monitor OpenTelemetry] Update Configuration Documentation to Include Log/Span Processors [Monitor OpenTelemetry] Update Configuration Documentation to Include Log/Span Processors and Use SpanProcessors in Default Config Mar 12, 2024
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit 75526c0 into Azure:main Mar 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants