Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS linter baseline error file #27960

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

JimSuplizio
Copy link
Member

CODEOWNERS is now going to be linted. This PR contains the existing linter errors, deduped, which are used to filter results, otherwise this pipeline couldn't be run on PRs that contain CODEOWNERS changes without the several hundred issues being fixed, which is not ideal. The linter will run daily and on every change to CODEOWNERS or the baseline file. Specific details of the linting can be found here but here is what's being verified in a nutshell.

  • Metadata tags - PRLabels, ServiceLabels, ServiceOwners (previously /<NotInRepo>/, both are still valid for the moment) and AzureSdkOwners (new, used for issue triage).
  • Source paths - Does the path exist? If the path is a glob, is it valid and does it have matches in the repository?
  • Owners - There are several verifications for owners:
    • Does the owner, individual or team, have write access (every team/individual in a CODEOWNERS file needs to have write access, this is a GitHub thing).
    • Is the owner public? Individuals need to set their Azure membership to public. This is explicitly mentioned in the onboarding documents for azure-sdk repositories.

@JimSuplizio JimSuplizio merged commit 2891db6 into Azure:main Dec 1, 2023
6 checks passed
@JimSuplizio JimSuplizio deleted the AddCodeownersBaseline2 branch December 1, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants