Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure/eventgrid] - Azure EventGrid Beta Release V5.1.0-beta.1 #27666

Merged

Conversation

sarangan12
Copy link
Member

@sarangan12 sarangan12 commented Nov 7, 2023

Packages impacted by this PR

@azure/eventgrid

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

  1. The EventGrid Service team has made changes to their CADL specification. This PR regenerates the SDK using the latest CADL specification.
  2. Important changes in this PR:
    i. A new API renewCloudEventLocks has been added.
    ii. In the publishCloudEvent API, a new option binaryMode has been added. This enables the users to send in the binary encoded event.
    iii. There are some other minor changes and some breaking changes also in this PR.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

One of the design decisions is around the binaryMode. Currently, the API accepts only binary encoded data for this API. If there is a requirement in the future that the user prefers that the encoding be done by the SDK, we could consider it in future,

Are there test cases added in this PR? (If not, why?)

Yes. New test cases have been added to test the binaryMode and the new renewCloudEventLocks API.

Provide a list of related PRs (if any)

  1. [@azure/eventgrid] Fix the Push Issue with the PublishCloudEvents API #26307
  2. [@azure/eventgrid] - Azure EventGrid Beta Release V4.13.0-beta.1 #25906

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@xirzec Please review and approve the PR & API Views.

API View to approve

  1. Link 1 (This compares this Beta 3 version with Beta 2 version which gives you a clear view of the changes)
  2. Link 2 (This is generated automatically by the PR Bot wgich compares the Beta 3 version with latest GA which is not correct. But, in order to release the SDK, we need the approval for the same. So, kindly review the Link 1 and approve both). Thanks

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-eventgrid

@sarangan12 sarangan12 changed the title Initial Code Changes for EG 4.13.0-beta.2 [@azure/eventgrid] - Azure EventGrid Beta Release V4.13.0-beta.1 Nov 7, 2023
@sarangan12 sarangan12 changed the title [@azure/eventgrid] - Azure EventGrid Beta Release V4.13.0-beta.1 [@azure/eventgrid] - Azure EventGrid Beta Release V4.13.0-beta.3 Nov 7, 2023
@sarangan12 sarangan12 marked this pull request as ready for review November 7, 2023 22:30
@sarangan12 sarangan12 merged commit 3f35281 into Azure:feature/eventgrid/4_13_beta_1 Nov 10, 2023
22 checks passed
@sarangan12 sarangan12 changed the title [@azure/eventgrid] - Azure EventGrid Beta Release V4.13.0-beta.3 [@azure/eventgrid] - Azure EventGrid Beta Release V5.1.0-beta.1 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants