Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engsys] update platform matrix for node 14 deprecation #27302

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Oct 2, 2023

Describe the problem that is addressed by this PR

Update the CI matrix so we are no longer testing on Node 14 as it has reached the end of our EOL + 6 months policy.

For coverage and browser legs I bumped it to use the current LTS (18) rather than 16 which is EOL, since most customers are not expected to be using an out of support runtime.

@benbp
Copy link
Member

benbp commented Oct 2, 2023

A few other matrices where 14.x is used:



@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@xirzec
Copy link
Member Author

xirzec commented Oct 3, 2023

The keyvault failure looks unrelated since it's a recorder issue in secrets and I didn't change the platform configuration for it. I think I'm going to go ahead and merge to get this in, but /cc @timovv for awareness, so he might disparage me for my sins if I am regressing anything

@xirzec
Copy link
Member Author

xirzec commented Oct 3, 2023

/check-enforcer override

@xirzec xirzec enabled auto-merge (squash) October 3, 2023 17:48
@xirzec xirzec merged commit e5f2bbc into main Oct 3, 2023
30 of 32 checks passed
@xirzec xirzec deleted the updateNodeMatrix branch October 3, 2023 17:48
jeremymeng pushed a commit to jeremymeng/azure-sdk-for-js that referenced this pull request Nov 7, 2023
[engsys] update platform matrix for node 14 deprecation (Azure#27302)

Update the CI matrix so we are no longer testing on Node 14 as it has
reached the end of our EOL + 6 months policy.

For coverage and browser legs I bumped it to use the current LTS (18)
rather than 16 which is EOL, since most customers are not expected to be
using an out of support runtime.
jeremymeng added a commit that referenced this pull request Nov 7, 2023
[engsys] update platform matrix for node 14 deprecation (#27302)

Update the CI matrix so we are no longer testing on Node 14 as it has
reached the end of our EOL + 6 months policy.

For coverage and browser legs I bumped it to use the current LTS (18)
rather than 16 which is EOL, since most customers are not expected to be
using an out of support runtime.

Co-authored-by: Jeff Fisher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants