Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI] Update the min dep version of @azure-rest/core-client #27012

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

deyaaeldeen
Copy link
Member

Packages impacted by this PR

@azure/openai

Issues associated with this PR

#27006

Describe the problem that is addressed by this PR

OperationOptions was exported in @azure-rest/[email protected] so we need to use this minimum version in openai.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

N/A

Are there test cases added in this PR? (If not, why?)

N/A

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the OpenAI label Sep 5, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@deyaaeldeen deyaaeldeen marked this pull request as ready for review September 5, 2023 17:33
@deyaaeldeen deyaaeldeen merged commit 1f74d0a into main Sep 5, 2023
@deyaaeldeen deyaaeldeen deleted the openai/update-core-dep-ver branch September 5, 2023 17:50
dgetu pushed a commit that referenced this pull request Sep 6, 2023
### Packages impacted by this PR
@azure/openai

### Issues associated with this PR
#27006

### Describe the problem that is addressed by this PR
`OperationOptions` was exported in @azure-rest/[email protected] so we
need to use this minimum version in openai.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
N/A

### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants