[OpenAI] Prepare beta.5 release #26941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
reviewed
Aug 25, 2023
| ``` | ||
|
|
||
| Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform): | ||
|
|
||
| ```bash | ||
| npx cross-env ENDPOINT="<endpoint>" AZURE_API_KEY="<azure api key>" node chatCompletions.js | ||
| npx cross-env ENDPOINT="<endpoint>" AZURE_API_KEY="<azure api key>" AZURE_SEARCH_ENDPOINT="<azure search endpoint>" AZURE_SEARCH_KEY="<azure search key>" AZURE_SEARCH_INDEX="<azure search index>" node bringYourOwnData.js |
There was a problem hiding this comment.
Do we specifically say here that it requires the cross-env npm module?
There was a problem hiding this comment.
npx is used and should install it automatically for you, no?
There was a problem hiding this comment.
Not necessarily, for example on Mac it doesn't:
npx cross-env FOO="bar" dist/index.js
sh: cross-env: command not foundThere was a problem hiding this comment.
Interesting, @witemple-msft could this be a gap in our sample READMEs?
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
Aug 25, 2023
| console.error("The sample encountered an error:", err); | ||
| }); | ||
|
|
||
| module.exports = { main }; |
There was a problem hiding this comment.
What is the usage of exporting main here?
There was a problem hiding this comment.
@witemple-msft Is this needed in order to run the sample in some pipeline?
mpodwysocki
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.