Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication][communication-alpha-ids] Update swagger - Include pre-registered alpha ids #26274

Merged
merged 9 commits into from
Jun 27, 2023

Conversation

rtrevino89
Copy link
Contributor

@rtrevino89 rtrevino89 commented Jun 20, 2023

Updating communication-alpha-ids swagger.

-- Adding new tests for the new endpoints.

The new endpoints design is the following:

image

numberType param was removed and "number" param was replaced by "value" in the AlphaID object.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-tools-communication-alpha-ids

@rtrevino89 rtrevino89 force-pushed the rtrevino/alphas-prereg branch from 1bcdcac to f66bf5a Compare June 23, 2023 20:47
@rtrevino89
Copy link
Contributor Author

/azp run js - communication-alpha-ids - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rtrevino89
Copy link
Contributor Author

/azp run js - communication-alpha-ids - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rtrevino89 rtrevino89 changed the title Rtrevino/alphas prereg [Communication][communication-alpha-ids] Update swagger - Include pre-registered alpha ids Jun 26, 2023
@rtrevino89
Copy link
Contributor Author

/azp run js - communication-alpha-ids - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rtrevino89
Copy link
Contributor Author

/azp run js - communication-alpha-ids - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rtrevino89 rtrevino89 marked this pull request as ready for review June 26, 2023 23:37
@rtrevino89 rtrevino89 merged commit c979e82 into Azure:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants