[language text] Remove auto language detection tests & update healthcare expectations #25891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
deyaaeldeen
reviewed
May 16, 2023
| { name: "SNOMEDCT_US", entityId: "133931009" }, | ||
| ], | ||
| text: "Baby", | ||
| category: "Age", | ||
| category: "FamilyRelation", |
There was a problem hiding this comment.
hmm, do you think a family relation implies there is another related entity, parent, that should be linked here?
There was a problem hiding this comment.
It would make sense to have that link because it does recognize the text for "mother" here, but they are not linked together. Also, this seems to have been a bug before because for this test, the text "baby" appeared twice, but once is recognized as "Age" and one is "FamilyRelation"
There was a problem hiding this comment.
Interesting finding! may be it is a good idea to ask @gils-ms about it?
minhanh-phan
added a commit
to minhanh-phan/azure-sdk-for-js
that referenced
this pull request
Jun 12, 2023
…are expectations (Azure#25891) Remove auto language detection test to prepare for release, update healthcare related expectations.
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Sep 28, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-08-02-preview (Azure#25891) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview * Updates readme * Updates API version in new specs and examples * update (Azure#25469) * Fix the IstioComponents structure (Azure#25492) * add netorkPolicy "none" (Azure#25511) * add netorkPolicy "none" value and description * add "none" enum value to networkPolicy * add addon autoscaling api (Azure#25479) * Update trusted access put and delete to async operation (Azure#25537) * Update trusted access put and delete to async operation * Update example * Update header * Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (Azure#25487) * Adding json changes * adding "daemonsets" to the custom-words * Editing "Expander" to "expander" * Removing daemonset custom word from this pr. look at: Azure/azure-rest-api-specs#25533 * Add AzureServiceMesh example (Azure#25560) * Add AzureServiceMesh example * Fix AKV resource id format * enrich ASM examples (Azure#25598) --------- Co-authored-by: deveshdama <[email protected]> Co-authored-by: robogatikov <[email protected]> Co-authored-by: Chih-Sheng Huang <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Youn Jae Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
ai-languate-text
Issues associated with this PR
Remove auto language detection test to prepare for release, update healthcare related expectations.
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists