Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] Add SDK for recipient verification (verified recipients) #25112

Merged
merged 25 commits into from
Mar 10, 2023
Merged

[Communication] Add SDK for recipient verification (verified recipients) #25112

merged 25 commits into from
Mar 10, 2023

Conversation

classBabacar-msft
Copy link
Contributor

@classBabacar-msft classBabacar-msft commented Mar 6, 2023

This is the (internal) SDK for 2FV (2-Factor Verification), currently, for trial phone numbers any developer can call or text anyone without restrictions. To reduce the risk of this happening, we add verification to where every number sent a message/called to needs to be verified beforehand.

On a high level all of these endpoints are here to achieve that:

request verification - requesting a code to be sent to a number for verification
verify verification - we verify the code sent to you and if it is correct then your number becomes verified
gets verification - get all of the verified/pending numbers for a user/developer
delete verification - remove a verified number

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 6, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-tools-communication-verified-recipients
azure-tools-communication-recipient-verification

@witemple-msft
Copy link
Member

Could you please add a PR title that explains what this PR does and fill in a description rather than leaving the template blank? You can remove all the template contents if they aren't relevant but some kind of description would be helpful.

@classBabacar-msft classBabacar-msft changed the title Internal SDK Internal SDK for verified recipients. Mar 7, 2023
@classBabacar-msft classBabacar-msft changed the title Internal SDK for verified recipients. SDK for verified recipients. Mar 7, 2023
@classBabacar-msft classBabacar-msft requested review from HarshaNalluru and rtrevino89 and removed request for HarshaNalluru and rtrevino89 March 8, 2023 00:19
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of dev dependencies have been upgraded/removed in the repo. Please take the suggested changes and run rush update again then commit the updated pnpm-lock.yml file.

@classBabacar-msft classBabacar-msft requested review from jeremymeng and removed request for HarshaNalluru March 8, 2023 00:46
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :shipit:

@jeremymeng jeremymeng changed the title SDK for verified recipients. [Communication] Add SDK for recipient verification (verified recipients) Mar 10, 2023
@jeremymeng jeremymeng merged commit d85f551 into Azure:main Mar 10, 2023
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Aug 22, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-07-02-preview (Azure#25254)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-06-02-preview to version 2023-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#25049)

* add new field resourceUID to managed cluster properties (Azure#25069)

* add new field resourceUID to managed cluster properties

https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp/pullrequest/8416789

* update description

* Mark guardrailsProfile Version as not required (Azure#25081)

* Mark guardrailsProfile Version as not required

* Run prettier

---------

Co-authored-by: Nick Keller <[email protected]>

* Swagger Changes for Multiple DNS Zones for Web App Routing (Azure#25064)

* added web app routing changes for multiple dns zones

* modified examples

* Changes for unified azuremonitorprofile in Microsoft.ContainerService (Azure#25063)

* Changes for unified azuremonitorprofile

* Update prettier changes

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

---------

Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]>
Co-authored-by: FumingZhang <[email protected]>

* Add cost analysis to AKS preview Swagger (Azure#25082)

* update preview API to follow GA api - use one forceupgrade boolean in… (Azure#25099)

* update preview API to follow GA api - use one forceupgrade boolean instead of multiple overrides

* update msg

---------

Co-authored-by: Wenjun Gao <[email protected]>

* Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)

* Mark trusted access role binding PUT and DELETE operation as async

* fix CI: update TA oepration's error to common type error

* Swagger for Machine API (Azure#25180)

* Swagger for Machine List, Get API

Related work items: #24759018

* Update managedClusters.json

* Update managedClusters.json

* Update MachineGet.json

adding new line

* Update MachineList.json

* Update managedClusters.json

* Update managedClusters.json

* Update managedClusters.json

* swagger: machine api

* swagger: machine api

* swagger:machine api

* swagger: machine api

* swagger: machine api

* swagger: machine api

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

* swagger: machine api

* swagger: machine api

* swagger:  machine api

* swagger:machine api

* swagger:machine api

* swagger:machine api

---------

Co-authored-by: FumingZhang <[email protected]>

* Adding Guardrails version to public swagger (Azure#25085)

* Adding Guardrails version to public swagger

* renamed GetGuardrailsVersions.json

* Applied GetCollectionResponseSchema rule

* Ran prettier fix

* Minor change

* moving parametre into managedClusters.json

* GuardrailsAvailableVersion model change

* Updated version param reference

* Swagger SemanticValidation fix

* model changes

* prettier fix

* Added version in list response

* Changed  to resource in GET and added descriptions where needed

* Removed identifier in GuardrailsAvailableVersionsList

---------

Co-authored-by: Sindhuja Salla <[email protected]>

* Remove overlay vpa unused properties (Azure#25242)

* remove unused properties

* only remove from required section

* remove the whole properties

---------

Co-authored-by: zhifanhui <[email protected]>

* asm: update examples to use asm- prefix for revisions (Azure#25247)

* Revert "Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)" (Azure#25233)

This reverts commit db24ef8bfbf6b214310af0872a923130e27ae1b6.

* fix AgentPoolNameParameter location

* Fuming zhang containerservice microsoft.container service 2023 07 02 preview (Azure#25433)

* adding requested properties.

* adding requested properties

* prettier check

* removing read-only constraint

---------

Co-authored-by: daru__ <[email protected]>
Co-authored-by: Nick Keller <[email protected]>
Co-authored-by: Nick Keller <[email protected]>
Co-authored-by: Jaiveer Katariya <[email protected]>
Co-authored-by: Janvi Jatakia <[email protected]>
Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Co-authored-by: Wenjun Gao <[email protected]>
Co-authored-by: Wenjun Gao <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: sushmak295 <[email protected]>
Co-authored-by: sallasindhuja <[email protected]>
Co-authored-by: Sindhuja Salla <[email protected]>
Co-authored-by: huizhifan <[email protected]>
Co-authored-by: zhifanhui <[email protected]>
Co-authored-by: Sanya Kochhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants