[core-client-rest] Set comma as parametrized path delimiter #24997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
joheredi
requested review from
xirzec,
jeremymeng and
deyaaeldeen
as code owners
jeremymeng
reviewed
Feb 24, 2023
| @@ -103,7 +103,7 @@ function buildRoutePath( | |||
| value = encodeURIComponent(pathParam); | |||
| } | |||
|
|
|||
| routePath = routePath.replace(/{([^/]+)}/, value); | |||
| routePath = routePath.replace(/{([^/,]+)}/, value); | |||
There was a problem hiding this comment.
are there other valid separators that we care about?
There was a problem hiding this comment.
I haven't found any other separators. However your comment got me thinking we could use a more robust regex like
/\{\w+\}/ which doesn't really need it to care about separators
|
API change check API changes are not detected in this pull request. |
deyaaeldeen
approved these changes
Feb 25, 2023
NickKouds
approved these changes
Feb 25, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure-rest/core-client
Issues associated with this PR
#24982
Describe the problem that is addressed by this PR
Currently core-client-rest fills in parameterized paths assuming that there will be only one parametrized element in a given path part. As surfaced in the linked issue, there are scenarios where a single path part can have more than one parameter.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Currently we only consider
/as a delimiter to look for the next path parameter. Adding,as a delimiter addresses this issue.Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
N/A