[core-util] Edit delay() #24801
Merged
[core-util] Edit delay() #24801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
deyaaeldeen
commented
Feb 8, 2023
jeremymeng
approved these changes
Feb 8, 2023
|
API change check API changes are not detected in this pull request. |
xirzec
approved these changes
Feb 8, 2023
sdk/core/core-util/src/delay.ts
Outdated
| @@ -28,38 +27,24 @@ export interface DelayOptions { | |||
| */ | |||
| export function delay(timeInMs: number, options?: DelayOptions): Promise<void> { | |||
| return new Promise((resolve, reject) => { | |||
| let timer: ReturnType<typeof setTimeout> | undefined = undefined; | |||
| let onAborted: (() => void) | undefined = undefined; | |||
|
|
|||
| const rejectOnAbort = (): void => { | |||
There was a problem hiding this comment.
since we're cleaning this up, it might be nicer to have these simply be named functions instead of anonymous ones bound to a local const:
function rejectOnAbort() {|
|
||
| const StandardAbortMessage = "The operation was aborted."; | ||
| const StandardAbortMessage = "The delay was aborted."; |
There was a problem hiding this comment.
I think some Storage tests at least might be sniffing the message, so you could see some failures with brittle tests. I tried to clean most of that up recently, but fair warning. :)
There was a problem hiding this comment.
The packages in the CI pipeline seem to be happy but if you come across any such failure, please pass it my way and I will address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor edit to use modern syntax and simpler control flow.