-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datafactory release #24700
Merged
Merged
datafactory release #24700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazrael2119
requested review from
ckairen,
witemple-msft,
deyaaeldeen,
jeremymeng,
qiaozha,
dw511214992 and
MaryGao
as code owners
February 3, 2023 08:33
qiaozha
reviewed
Feb 8, 2023
API change check APIView has identified API level changes in this PR and created following API reviews. |
MaryGao
reviewed
Feb 17, 2023
sdk/datafactory/arm-datafactory/samples/v11/javascript/activityRunsQueryByPipelineRunSample.js
Show resolved
Hide resolved
MaryGao
reviewed
Feb 17, 2023
MaryGao
reviewed
Feb 17, 2023
MaryGao
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The breaking introduced here: Azure/azure-rest-api-specs#21535 and since it is more than a year compared with major version I think we could accept it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offline confirmed with the release request owner, It's good to publish one pr for this two release requests
https://github.com/Azure/sdk-release-request/issues/3661
https://github.com/Azure/sdk-release-request/issues/3747