Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault] Migrate keyvault-secrets to new recorder #23496

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

timovv
Copy link
Member

@timovv timovv commented Oct 12, 2022

Packages impacted by this PR

  • @azure/keyvault-secrets

Issues associated with this PR

Describe the problem that is addressed by this PR

Migrates keyvault-secrets to recorder 2.0

@timovv timovv requested a review from HarshaNalluru October 12, 2022 23:44
@ghost ghost added the KeyVault label Oct 12, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@timovv timovv requested a review from minhanh-phan October 13, 2022 00:26
Copy link
Member

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know about the skipped flaky tests.

@timovv timovv merged commit 1154fab into Azure:main Oct 17, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request May 26, 2023
Release app microsoft.app 2023 04 01 preview (Azure#24103)

* Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* support terminationGracePeriodSeconds (Azure#23476)

* Support SubPath in volume mount and mount options for azure file volume (Azure#23496)

* Support SubPath in volume mount and mount options for azure file volume

* update description

* Add replica/container running state (Azure#23617)

* add replica/container running state

* spell error fix

* add event trigger for Container Jobs 2023-04-01-preview (Azure#23724)

* add event trigger for Container Jobs 2023-04-01-preview

* prettier and avocado fix

---------

Co-authored-by: Taher Darolywala <[email protected]>

* Resolve Comments for Event driven jobs (Azure#23729)

* Resolve Comments for Event driven jobs

* change scaling rule to azure-servicebus

* update example

---------

Co-authored-by: Taher Darolywala <[email protected]>

* Swagger change for mtls and runningState (Azure#23767)

* 1. Add mtls properties for managed ManagedEnvironment
2. Add running state for Revision

* fix

* Add ContainerApp Start/Stop for 2023-04-01-preview (Azure#23497)

* Add ContainerApp Start/Stop for 2023-04-01-preview

* Fix validation error

* Fix validation error

* Change example to add location in header

* Fix lint error

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Add new source controls properties (Azure#23891)

* Add new source controls properties

* Update examples

* fix examples

* Change event trigger replica properties to executions, add polling in… (Azure#23810)

* Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs

* Fix validation errors

* code review comments

* Fix formatting errors

* Code review comments

* Add single execution history endpoint, refactor copy paste code for j… (Azure#23816)

* Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters

* Fix validation errors from ARM

* Fix validation errors

* Code review comments

* Fix validation error

* code review comments from Anand

* Add springboard properties (Azure#23932)

* Add springboard properties

* CR comments

* Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json

Co-authored-by: Jitin John <[email protected]>

* Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json

Co-authored-by: Jitin John <[email protected]>

---------

Co-authored-by: Jitin John <[email protected]>

* Fix Lint issues in ContainerApps.json (Azure#24107)

* Fix lint issue

* Fix format issue

* Fix json format issue

* Fix model validation

* Fix lint error

* fix param (Azure#24166)

Co-authored-by: Chenghui Yu <[email protected]>

---------

Co-authored-by: Zunli Hu <[email protected]>
Co-authored-by: njucz <[email protected]>
Co-authored-by: LaylaLiu-gmail <[email protected]>
Co-authored-by: Xingjian Wang <[email protected]>
Co-authored-by: Taher Daroly <[email protected]>
Co-authored-by: Taher Darolywala <[email protected]>
Co-authored-by: zhenqxuMSFT <[email protected]>
Co-authored-by: Zijian-Ju <[email protected]>
Co-authored-by: Sanchit Mehta <[email protected]>
Co-authored-by: trajkobal <[email protected]>
Co-authored-by: Ahmed ElSayed <[email protected]>
Co-authored-by: Jitin John <[email protected]>
Co-authored-by: Seris370 <[email protected]>
Co-authored-by: Chenghui Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Vault Secrets - Move to the new proxy server based recorder
3 participants