Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Rename idempotent retries flag #21730

Merged
merged 1 commit into from
May 5, 2022
Merged

[Event Hubs] Rename idempotent retries flag #21730

merged 1 commit into from
May 5, 2022

Conversation

deyaaeldeen
Copy link
Member

To align with .NET.

@ghost ghost added the Event Hubs label May 5, 2022
@deyaaeldeen deyaaeldeen requested a review from jsquire May 5, 2022 17:33
jsquire
jsquire reviewed May 5, 2022
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from the API perspective. I'll defer approval to the JS experts.

@azure-sdk
Copy link
Collaborator

API change check for @azure/event-hubs

API changes have been detected in @azure/event-hubs. You can review API changes here

API changes

-     enableIdempotentPartitions?: boolean;
+     enableIdempotentRetries?: boolean;

jeremymeng
jeremymeng approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deyaaeldeen deyaaeldeen merged commit 45b9a05 into Azure:main May 5, 2022
@deyaaeldeen deyaaeldeen deleted the eventhubs/rename-idempotent-flag branch May 5, 2022 19:01
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Dec 8, 2022
@p-bouchon @ruslany
@zhenqxuMSFT @najian
CodeGen from PR 21683 in Azure/azure-rest-api-specs
daa139b 
Release app microsoft.app 2022 10 01 (Azure#21683)

* Adds base for updating Microsoft.App from version preview/2022-06-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AppState and LatestReadyRevisionName (Azure#21034)

* Add new props

* add defaults

* Add swagger for client cert & CORS policy (Azure#21126)

* Fix password format of env domain for 2022-10-01 (Azure#21463)

* fix

* fix

* Remove AppState property as we decided to postpone it (Azure#21483)

* Remove AppState property as we decided to postpone it

* Fix swagger issues

* More swagger fixes

* s360 swagger correctness fixes (Azure#21472)

Co-authored-by: Nan Jiang <[email protected]>

* Add kind for managed environment (Azure#21589)

* add

* fix

* fix (Azure#21730)

* fix (Azure#21747)

Co-authored-by: p-bouchon <[email protected]>
Co-authored-by: Ruslan Yakushev <[email protected]>
Co-authored-by: zhenqxuMSFT <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire left review comments

@jeremymeng jeremymeng jeremymeng approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru HarshaNalluru is a code owner

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deyaaeldeen @azure-sdk @jsquire @jeremymeng