-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated functionality for Operator Connect MVP0. #21725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Communication
Mgmt
This issue is related to a management-plane library.
labels
May 5, 2022
API change check for API changes have been detected in API changes + export declare type PhoneNumberSource = "cloud" | "operatorConnect";
+ operatorId: string;
+ operatorName: string;
+ phoneNumberSource: PhoneNumberSource; |
jiriburant
requested review from
bterlson,
xirzec,
jeremymeng,
miguhern,
whisper6284,
lucasrsant,
RoyHerrod and
danielav7
as code owners
May 12, 2022 18:01
jiriburant
commented
May 12, 2022
sdk/communication/communication-phone-numbers/test/public/lro.purchaseAndRelease.spec.ts
Outdated
Show resolved
Hide resolved
lucasrsant
reviewed
May 13, 2022
...rowsers/phonenumbersclient__get_phone_number/recording_can_get_a_purchased_phone_number.json
Show resolved
Hide resolved
...ers/phonenumbersclient__get_phone_number_aad/recording_can_get_a_purchased_phone_number.json
Outdated
Show resolved
Hide resolved
...s/browsers/phonenumbersclient__lists_aad/recording_can_list_all_purchased_phone_numbers.json
Show resolved
Hide resolved
...bersclient__lro__purchase_and_release/recording_can_purchase_and_release_a_phone_number.json
Outdated
Show resolved
Hide resolved
...client__lro__purchase_and_release_aad/recording_can_purchase_and_release_a_phone_number.json
Show resolved
Hide resolved
...client__lro__purchase_and_release_aad/recording_can_purchase_and_release_a_phone_number.json
Show resolved
Hide resolved
...ersclient__lro__search_aad/recording_can_search_for_1_available_phone_number_by_default.json
Outdated
Show resolved
Hide resolved
...wsers/phonenumbersclient__lro__update/recording_can_update_a_phone_numbers_capabilities.json
Outdated
Show resolved
Hide resolved
.../recordings/node/phonenumbersclient__lists/recording_can_list_all_purchased_phone_numbers.js
Show resolved
Hide resolved
petrsvihlik
suggested changes
May 16, 2022
sdk/communication/communication-phone-numbers/review/communication-phone-numbers.api.md
Show resolved
Hide resolved
petrsvihlik
suggested changes
May 17, 2022
petrsvihlik
approved these changes
May 17, 2022
lucasrsant
approved these changes
May 17, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Dec 1, 2022
add missing workspace properties (Azure#21725)
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Feb 1, 2023
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761) * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Add Dec API Registries Swagger (Azure#21419) * add december registries swagger + examples * add status code 202 in examples * fix 202 examples * fixes * fixes * fix * add 202 back in for put/patch Co-authored-by: Komal Yadav <[email protected]> * remove location (Azure#21430) Co-authored-by: Komal Yadav <[email protected]> * remove readonly flag on schedules property for CI (Azure#21653) Co-authored-by: Naman Agarwal <[email protected]> * add missing workspace properties (Azure#21725) * December preview updating mfe.json specs (Azure#21510) * December preview updating mfe.json specs * MFE Dec 2022 Preview API - Adding logbase * MFE 2022-12-01-preview swagger spec model validation fix * MFE 2022-12-01-preview swagger spec model validation fix, add missing location * MFE 2022-12-01-preview swagger spec model validation - typo fix * MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error * Fix for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822) * fix ReadonlyPropertyChanged of MLC (Azure#21814) Co-authored-by: Bingchen Li <[email protected]> * fixed custom-words conflict (Azure#21829) * fix custom-words conflict merge (Azure#21830) * example fix (INVALID_REQUEST_PARAMETER) (Azure#21832) Co-authored-by: Ivaliy Ivanov <[email protected]> * example fix, use correct api preview version - (INVALID_REQUEST_PARAMETER) (Azure#21833) Co-authored-by: Ivaliy Ivanov <[email protected]> * Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885) Co-authored-by: Bingchen Li <[email protected]> * Revert Connection Category back to enum. (Azure#21939) * revert provisioning state change (Azure#21940) * remove body (Azure#21978) Co-authored-by: Komal Yadav <[email protected]> * Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005) * Addressed comments, added x-ms-long-running-operation to a patch call * fix examples for patch - remove body * fixed formatting * Ivalbert fix patch2 (Azure#22006) * Addressed comments, added x-ms-long-running-operation to a patch call * fix examples for patch - remove body * fixed formatting * fixed formatting * Updated custom words (Azure#22262) * Fixed prettier errors (Azure#22237) * fixed examples for LRO_RESPONSE_HEADER check (Azure#22293) * fixed examples for LRO_RESPONSE_HEADER check (Azure#22294) * Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (#22317) --------- Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Ivaliy Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/communication-phone-numbers
Issues associated with this PR
Describe the problem that is addressed by this PR
We are adding missing fields in the PurchasedPhoneNumber response, to provide information about the operator providing the number, as part of the new Operator Connect feature.
This will be consumed by the Portal UI and displayed.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
We want to simply list the operator info, so we add it to the returned PurchasedPhoneNumber object
Are there test cases added in this PR? (If not, why?)
No new test cases, we added a few fields to existing models.
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists