-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eventgrid] Fix nightly Min/Max CI issues #20126
[eventgrid] Fix nightly Min/Max CI issues #20126
Conversation
Similar to Azure#19862, we have recently started to see some issues in our nightly min/max jobs that prevent us from saving the entire Response object during the `onResponse` callback due to multiple imports of the "same" type. Similar to the resolution for Azure#19862, I've decided to just not use nominal types from `core-client` here and instead just stash away the parts of the response I need inside the callback and observe the values after. Fixes Azure#20014
/azp run eventgrid - js - tests |
No pipelines are associated with this pull request. |
/azp run js - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving this! I think this is probably the best solution without having to bump the min version of core-client
/azp run js - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Similar to #19862, we have recently started to see some issues in our
nightly min/max jobs that prevent us from saving the entire Response
object during the
onResponse
callback due to multiple imports of the"same" type.
Similar to the resolution for #19862, I've decided to just not use
nominal types from
core-client
here and instead just stash away theparts of the response I need inside the callback and observe the
values after.
Fixes #20014