[Identity] Fixing certificate test inconsistencies, including min-max live tests. #19810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
It makes the lives tests fail with |
sadasant
force-pushed
the
identity/moved-assets-min-max
branch
from
2cf600e to
73e5717
Compare
sadasant
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR:
Describe the problem that is addressed by this PR:
We’re seeing min max tests fail for Identity on our nightly CI pipelines. After debugging this, Karishma spotted that our tests were unable to find the fake certificate. This PR skips the test if the certificate can’t be found. It also replaces the HTTP client with a client that will never resolve before the abort signal is aborted.