Update all uses of next to check done before consuming value #19637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Azure.Core
KeyVault
Storage
deyaaeldeen
force-pushed
the
core-paging/set-return-val-void
branch
from
7941ece to
1fda56d
Compare
deyaaeldeen
requested review from
EmmaZhu,
HarshaNalluru,
jeremymeng,
jiacfan,
KarishmaGhiya,
ljian3377,
maorleger,
sadasant,
timovv,
vinjiang,
witemple-msft and
XiaoningLiu
as code owners
xirzec
reviewed
Jan 5, 2022
| * @param iteratorResult The result of the current iteration | ||
| * @returns the currently yielded value | ||
| */ | ||
| export function getYieldedValue<YT, RT>(iteratorResult: IteratorResult<YT, RT>): YT { |
xirzec
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check
donebefore consumingvalueof anyIteratorResult. This PR adds a new test utility,getYieldedValue, that takes anIteratorResultas input and returns the yielded value if the iterator was not done yet, otherwise, it throws an assertion failure. Furthermore, this PR uses this utility in all tests that do not check the done field.The PR was inspired by #19507 (review)