-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified Recorder] New test-utils
package for test credential
#19423
Changes from 12 commits
b7a15ca
ca193b8
4b1a28d
b063605
d4428c6
d9393ed
100a848
7d79b8a
46dbee2
d96372e
10b997e
6d43a89
bca52d0
3d054ab
5c09e27
9ed57f3
88b5342
d10b3cf
31e8d53
f6887b2
508e92a
2aadb31
87592b2
4688488
65b52b0
3a7cd33
a1dcfa5
b49e850
ec1b501
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"plugins": ["@azure/azure-sdk"], | ||
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Release History | ||
|
||
## 1.2.0 (#Unreleased) | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### Features Added | ||
|
||
Provides the credential to be used in the tests. `NoOpCredential` in playback and `ClientSecretCredential` in record/live modes. | ||
[#19423](https://github.com/Azure/azure-sdk-for-js/pull/19423) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
The MIT License (MIT) | ||
|
||
Copyright (c) 2021 Microsoft | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# Azure @azure-tools/identity-extensions client library for JavaScript | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This library provides the credential for testing. | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Getting started | ||
|
||
### Installation | ||
|
||
Add this library as a dev dependency in your project. | ||
|
||
> rush add -p @azure-tools/identity-extensions --dev | ||
|
||
## Key concepts | ||
|
||
This library provides the credential to be used in the tests | ||
|
||
In playback mode | ||
|
||
- returns the `NoOpCredential` (helps bypass the AAD traffic) | ||
- `NoOpCredential` is defined in `@azure-tools/test-recorder-new` | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
In record/live modes | ||
|
||
- returns the `ClientSecretCredential` (expects AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET in your environment or in the .env file) | ||
- AAD traffic won't be recorded if this credential is used. | ||
- `ClientSecretCredential` is coming from `@azure/identity` | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Next steps | ||
|
||
Try out this package in your application and provide feedback! | ||
|
||
## Troubleshooting | ||
|
||
Log an issue at https://github.com/Azure/azure-sdk-for-js/issues | ||
|
||
## Contributing | ||
|
||
If you'd like to contribute to this library, please read the [contributing guide](https://github.com/Azure/azure-sdk-for-js/blob/main/CONTRIBUTING.md) to learn more about how to build and test the code. | ||
|
||
![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Ftest-utils%2Ftest-utils-identity%2FREADME.png) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
{ | ||
"name": "@azure-tools/identity-extensions", | ||
witemple-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"version": "1.0.0", | ||
"sdk-type": "utility", | ||
"description": "Test utilities library for the Azure SDK for JavaScript and TypeScript", | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"main": "dist/index.js", | ||
"module": "dist-esm/src/index.js", | ||
"browser": { | ||
"./dist-esm/src/global.js": "./dist-esm/src/global.browser.js" | ||
}, | ||
"types": "./types/latest/src/index.d.ts", | ||
"engines": { | ||
"node": ">=12.0.0" | ||
}, | ||
"scripts": { | ||
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit", | ||
"build": "npm run clean && tsc -p . && rollup -c 2>&1", | ||
"build:samples": "echo Skipped.", | ||
"build:test": "echo not needed", | ||
"check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | ||
"clean": "rimraf dist dist-* types *.tgz *.log", | ||
"format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | ||
"integration-test:browser": "echo skipped", | ||
"integration-test:node": "echo skipped", | ||
"integration-test": "npm run integration-test:node && npm run integration-test:browser", | ||
"lint:fix": "eslint --no-eslintrc -c ../../.eslintrc.internal.json package.json src test --ext .ts --fix --fix-type [problem,suggestion]", | ||
"lint": "eslint --no-eslintrc -c ../../.eslintrc.internal.json package.json src test --ext .ts", | ||
"pack": "npm pack 2>&1", | ||
"unit-test:browser": "echo skipped", | ||
"unit-test:node": "echo skipped", | ||
"unit-test": "npm run unit-test:node && npm run unit-test:browser", | ||
"test:browser": "npm run clean && npm run build npm run unit-test:browser", | ||
"test:node": "npm run clean && npm run build && npm run unit-test:node", | ||
"test": "npm run clean && npm run build && npm run unit-test" | ||
}, | ||
"files": [ | ||
"dist/", | ||
"dist-esm/src/", | ||
"types/src/index.d.ts", | ||
"README.md", | ||
"LICENSE" | ||
], | ||
"repository": "github:Azure/azure-sdk-for-js", | ||
"keywords": [ | ||
"Azure", | ||
"cloud", | ||
"test", | ||
"framework" | ||
], | ||
"author": "Microsoft Corporation", | ||
"license": "MIT", | ||
"bugs": { | ||
"url": "https://github.com/Azure/azure-sdk-for-js/issues" | ||
}, | ||
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/test-utils/test-utils-identity/README.md", | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"sideEffects": false, | ||
"private": true, | ||
"dependencies": { | ||
"@azure-tools/test-recorder": "^1.0.0", | ||
"@azure-tools/test-recorder-new": "1.0.0", | ||
"@azure/identity": "^2.0.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Identity currently uses the recorder. Wouldn’t it be an issue? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. identity depends on
test-utils/identity-extensions depends on
every other SDK will depend on
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. identity doesn't depend on test-utils/identity-extensions, so there should not be a problem |
||
}, | ||
"devDependencies": { | ||
"@azure/dev-tool": "^1.0.0", | ||
"@azure/eslint-plugin-azure-sdk": "^3.0.0", | ||
"@types/chai": "^4.1.6", | ||
"@types/mocha": "^7.0.2", | ||
"@types/node": "^12.0.0", | ||
"eslint": "^7.15.0", | ||
"prettier": "^1.16.4", | ||
"rimraf": "^3.0.0", | ||
"rollup": "^1.16.3", | ||
"sinon": "^9.0.2", | ||
"typescript": "~4.2.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { makeConfig } from "@azure/dev-tool/shared-config/rollup"; | ||
|
||
export default makeConfig(require("./package.json")); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
import { ClientSecretCredential } from "@azure/identity"; | ||
import { env, isPlaybackMode } from "@azure-tools/test-recorder"; | ||
import { NoOpCredential } from "@azure-tools/test-recorder-new"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn’t NoOpCredential be moved to this package? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, can be done |
||
|
||
/** | ||
* ## Credential to be used in the tests. | ||
* | ||
* ### In playback mode | ||
* - returns the NoOpCredential (helps bypass the AAD traffic) | ||
* | ||
* ### In record/live modes | ||
* - returns the ClientSecretCredential (expects AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET in your environment or in the .env file) | ||
* - AAD traffic won't be recorded if this credential is used. | ||
*/ | ||
export function getTestCredential() { | ||
HarshaNalluru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return isPlaybackMode() | ||
? new NoOpCredential() | ||
: new ClientSecretCredential( | ||
env["AZURE_TENANT_ID"], | ||
env["AZURE_CLIENT_ID"], | ||
env["AZURE_CLIENT_SECRET"] | ||
); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "../../../tsconfig.package", | ||
"compilerOptions": { | ||
"outDir": "./dist-esm", | ||
"declarationDir": "./types/latest" | ||
}, | ||
"include": ["src/**/*.ts", "test/**/*.ts"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving fast 🔥