Applying comments from API Review #18662
Conversation
…erver-preview' into fmorales/azure_comments
cochi2
requested review from
bterlson,
jeremymeng,
ramya-rao-a and
xirzec
as code owners
Moving the Managed HSM to the same location as our resource group now that the limits have been expanded.
Co-authored-by: Ben Broderick Phillips <[email protected]>
…les/azure_comments
…re#18665) Co-authored-by: scbedd <[email protected]>
* [event-hubs] EventHubsBufferedProducerClient skeleton (Azure#17761) * temp transfer * [event-hubs] initial EventHubBufferedProducerClient skeleton * Change default value of BufferedCloseOptions.flush to true instead of false * Reorder doc comment content for EventHubBufferedProducerClient * remove eslint exception for @azure/azure-sdk/ts-naming-options in EventHubBufferedProducerClientOptions * add enqueueEvent (singular) method * update API view * [WIP][event-hubs] EventHubBufferedProducerClient implementation (Azure#18106) * transfer * [mock-hub] fix issue where calling stop() would not remove existing idle connection timeout watchers * [event-hubs] reduce repetition in hubruntime.spec.ts tests * Add support for flush,eventSuccess and eventError handlers, and backpressure to EventHubBufferedProducerClient * add documentation and update API to align with .NET * [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping (Azure#18331) * [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping * fix the implementation * factor out the hashing logic * remove unused import * the test pass but the implementation needs to be simplified * simplified implementation * address feedback * address feedback * fix format * address feedback Co-authored-by: chradek <[email protected]>
* [Event Hubs] Prepare release * remove empty sections
* Node doesn't support some samples for smoke test * [search-documents] reprocessed samples with exp. generator Co-authored-by: Will Temple <[email protected]>
* add llc quickstart guideline * update format * add documentation about ci.yml * update to resolve some comments * update to resolve some comments * update to resolve comments * updates term * update format * update format
cochi2
requested review from
praveenkuttappan and
witemple-msft
as code owners
cochi2
removed request for
deyaaeldeen,
mikeharder,
praveenkuttappan and
witemple-msft
* Improve devops logging for link checker * Update eng/common/scripts/Verify-Links.ps1 Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
…zure#18686) * Build and test predefined set of packages only in identity pipelines
…les/azure_comments
cochi2
requested review from
danieljurek,
HarshaNalluru,
maorleger,
sadasant,
sarangan12 and
weshaggard
as code owners
…erver-preview' into feature/communication-CallingServer-preview
…les/azure_comments
cochi2
removed request for
danieljurek,
HarshaNalluru,
maorleger,
sadasant,
sarangan12 and
weshaggard
[Hub Generated] Public private branch 'elastic-san-preview' (Azure#18148) * Initial Check-In to introduce ElasticSan RP * Applied coding styles and fixed the spelling mistake. * Updated with IOPS & MBps properties * Updated swagger file with NetWork Acls * Added "None" to protocol type and updated with other validations. * Removed ElasticSan from VolumeGroup operations * Addressed review comments by adding elasticSanName in each of its operation * Added volumeGroupName Parameters to the operations * Upated array item with "x-ms-identifiers": [] as per Swagger Lint recommendations * Removed unused parameters * Updated with Snapshot endpoints * Updated with missing "type" declarations * Added Snapshot changes and addressed the PR review comments * Fixed Lint differences * Fixed Lint difference * Added Export feature for Snapshot * Updated with Sku level settings * Updated with AdditionalInfo with "x-ms-identifiers": [] * Fixed Lint compilation issue with "x-ms-identifiers": [], * Fixed Prettier issues * Updated the readme* files with the right package and namespaces. * Pointed GO to track2 * Updated readme.go.md with the yaml format * Addressed review comments, updated with ecommon types and added naming restrictions. * Updated with common SystemData * Corrected the missing json structure * Updated 'CreateOrUpdate" with "Create" * Updated the spec with Network ACLs * Removed unnecessary error codes * Regenerated the examples * Removed Snapshot API and addressed PR comments (Azure#18638) * Removed Snapshot API and addressed PR comments * Removed Ruby SDK information (Azure#18662) * Reverted tsconfig.json and removed Ruby related SDK information. * Corrected the indentation for swagger-to-sdk Co-authored-by: Rajesh Kumar Aggani <[email protected]>
This PR covers:
downloadToFilemethod.