Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rlc quickstart guideline #18503
Add rlc quickstart guideline #18503
Changes from 2 commits
d53bd60
2e3b5bd
63a87d3
22822bc
c43f844
248737d
c77d193
fbc88a5
034a0a3
4a1de77
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this section to be "How to test your package", and remove
rushx pack
and suggestrushx test
instead. I don't think new developers would needrushx pack
very often.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to mention that a
.env
file needs to be setup with the credentials to use during test. And that we need to setTEST_MODE=record
to get the HTTP responses mocked and then setTEST_MODE=playback
to run agains the mocked responsesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added. But I think the default TEST_MODE is playback ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add the rushx pack step, because some service team may want a private artifact when they are still in private preview stage, with this hint, they don't need to ask us to send them an artifact.