[EventGrid] Fix Test Compilation Errors #16723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Azure#16700 we updated our tests to generate the key we used for testing by doing a base64 conversion of a fixed string so we didn't have something that looked like a key embeded in source which was upsetting some static analysis tools. This casues a build break in the min/max testing where `btoa` can't be found when building the test. Since we have the correct runtime behavior in the test to only call `btoa` when we are not in a node-context we simply reference the dom library to appease the compiler.
ghost
added
the
|
/azp run js - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - eventgrid - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@HarshaNalluru after your fix for the cred scan issue the nightly build was failing for the min/max testing legs (see: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1029970&view=results). The problem was we did not have a reference to the dom library when building in this mode (since the tests are built in their own context). I added a reference to the dom lib in the one spec file that used |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 19, 2022
Compute 2021-11-01 Release (Azure#17120) * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729e86b30440cdd3c239272e31dff7f9627b. * sync with last version * add missing examples * suppress bodyTopLevelProperties * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * add suppression for required properties * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd2260cb9e63ba16d8b15d405f3134fe612c1. * Remove impossible state from example (Azure#16544) * Downmerging change from Azure:main (Azure#16654) Co-authored-by: Avinash Akka <[email protected]> * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <[email protected]> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <[email protected]> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <[email protected]> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure/azure-rest-api-specs#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <[email protected]> * move Kashif's change to 2021-11-01 * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0638942c04275d69fd485ceb2da02a96d3. * fix CI failures, and run prettier on added examples * for credscan. change password example * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * make new api call long-running-operation * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729e86b30440cdd3c239272e31dff7f9627b. * sync with last version * add missing examples * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd2260cb9e63ba16d8b15d405f3134fe612c1. * Remove impossible state from example (Azure#16544) * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <[email protected]> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <[email protected]> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <[email protected]> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure/azure-rest-api-specs#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <[email protected]> * move Kashif's change to 2021-11-01 * fix CI failures, and run prettier on added examples * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0638942c04275d69fd485ceb2da02a96d3. * for credscan. change password example * make new api call long-running-operation * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * update Repair action to enum and update readme * rebase to main since 2021-08-01 merged. update readme * update x-ms-enum name for RepairType * add default response to operations * update * put back 'required' tag for Resource.Location property and use a new object for VM_LIST return object * fix json format * update examples * run prettier on updated examples * update example for credScan * add VirtualMachineResource for toplevel property suppression. * lint diff errors * lint diff fix update * remove change for VMextensions.location bug * return readme file and examples before vm.vmextension.location change Co-authored-by: sukodava <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: xielexie <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: ms-saypaul <[email protected]> Co-authored-by: Raktima Das <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: frank-pang-msft <[email protected]> Co-authored-by: Chase VanBuskirk <[email protected]> Co-authored-by: Chase Van Buskirk <[email protected]> Co-authored-by: vbhasker-msft <[email protected]> Co-authored-by: avjai <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: karthikka4820 <[email protected]> Co-authored-by: LexieXie <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16700 we updated our tests to generate the key we used for testing
by doing a base64 conversion of a fixed string so we didn't have something that looked like a key embedded in source which was upsetting some static analysis tools.
This causes a build break in the min/max testing where
btoacan't be found when building the test. Since we have the correct runtime behavior in the test to only callbtoawhen we are not in a node-context we simply reference the dom library to appease the compiler.