Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable orginal pipeline for mgmt in main branch #16026

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

dw511214992
Copy link
Member

@dw511214992 dw511214992 commented Jun 28, 2021

change the trigger in mgmt-ci.yml and mgmt-pr.yml to disable it in main branch (we will release track1 sdk in branch feature/v4)

@weshaggard
Copy link
Member

Do we not want to build any track 1 libraries in main at all? Would it make sense to just delete this yml file from main?

@ramya-rao-a
Copy link
Contributor

Do we not want to build any track 1 libraries in main at all? Would it make sense to just delete this yml file from main?

There are still Track 1 data plane auto generated libraries in the main branch. They use the same pipeline

@dw511214992
Copy link
Member Author

dw511214992 commented Jun 29, 2021

Do we not want to build any track 1 libraries in main at all? Would it make sense to just delete this yml file from main?

There are still Track 1 data plane auto generated libraries in the main branch. They use the same pipeline

@ramya-rao-a If there are still track1 dataplane libraries based on this pipeline, can we release them in another branch like mgmt libraries?

@weshaggard
Copy link
Member

My suggestion is to close this PR and use the generic set of filters I called out in #15993 in both main and everywhere else.

@dw511214992
Copy link
Member Author

My suggestion is to close this PR and use the generic set of filters I called out in #15993 in both main and everywhere else.

@weshaggard I hope to release track1 sdk in branch feature/v4 and the main branch is only for track2 sdk. So we need to disable the original pipeline for track1 in main branch.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely break any scheduled or ci triggers on the existing pipelines so you will want to make sure to update those in DevOps.

@dw511214992
Copy link
Member Author

dw511214992 commented Jul 1, 2021

This will likely break any scheduled or ci triggers on the existing pipelines so you will want to make sure to update those in DevOps.

@weshaggard yes. I have make changes to the following ci triggers/release pipeline in devops:
https://dev.azure.com/azure-sdk/public/_build?definitionId=525
https://dev.azure.com/azure-sdk/internal/_release?_a=releases&view=mine&definitionId=42
https://dev.azure.com/azure-sdk/public/_build?definitionId=138&_a=summary

As far as I know, I thnk only these 3 pipelines are for track1 mgmt sdk. If there are any pipeline I missed, please let me know.

@dw511214992 dw511214992 merged commit c07f91d into main Jul 1, 2021
@dw511214992 dw511214992 deleted the dw/disable-original-pipeline-for-mgmt branch July 1, 2021 06:36
@ramya-rao-a
Copy link
Contributor

If there are still track1 dataplane libraries based on this pipeline, can we release them in another branch like mgmt libraries?

I hope to release track1 sdk in branch feature/v4 and the main branch is only for track2 sdk. So we need to disable the original pipeline for track1 in main branch.

Releasing the handful Track 1 auto generated data plane packages from a separate branch is an overhead I would like to avoid. Can we not keep this pipeline for the main branch, but remove all the mgmt plane packages from the include list?

cc @qiaozha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants