-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable orginal pipeline for mgmt in main branch #16026
Conversation
Do we not want to build any track 1 libraries in main at all? Would it make sense to just delete this yml file from main? |
There are still Track 1 data plane auto generated libraries in the main branch. They use the same pipeline |
@ramya-rao-a If there are still track1 dataplane libraries based on this pipeline, can we release them in another branch like mgmt libraries? |
My suggestion is to close this PR and use the generic set of filters I called out in #15993 in both main and everywhere else. |
@weshaggard I hope to release track1 sdk in branch feature/v4 and the main branch is only for track2 sdk. So we need to disable the original pipeline for track1 in main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will likely break any scheduled or ci triggers on the existing pipelines so you will want to make sure to update those in DevOps.
@weshaggard yes. I have make changes to the following ci triggers/release pipeline in devops: As far as I know, I thnk only these 3 pipelines are for track1 mgmt sdk. If there are any pipeline I missed, please let me know. |
Releasing the handful Track 1 auto generated data plane packages from a separate branch is an overhead I would like to avoid. Can we not keep this pipeline for the main branch, but remove all the mgmt plane packages from the include list? cc @qiaozha |
change the trigger in mgmt-ci.yml and mgmt-pr.yml to disable it in main branch (we will release track1 sdk in branch feature/v4)