[Text Analytics] Re-record tests against v3.1 #15995
Conversation
deyaaeldeen
requested review from
maririos,
kristapratico,
iscai-msft and
mssfang
ghost
added
the
|
/azp run js - ai-text-analytics - ci |
|
No pipelines are associated with this pull request. |
|
/azp run js - textanalytics - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -500,7 +497,6 @@ main(); | |||
|
|
|||
| ## Known Issues | |||
|
|
|||
| - `beginAnalyzeHealthcareEntities` is still in gated preview and can not be used with AAD credentials. For more information, see [the Text Analytics for Health documentation](https://docs.microsoft.com/azure/cognitive-services/text-analytics/how-tos/text-analytics-for-health?tabs=ner#request-access-to-the-public-preview). | |||
| - At time of this SDK release, the `modelVersion` option to `beginAnalyzeHealthcareEntities` is ignored by the service. The service always processes the operation using the "latest" model. | |||
There was a problem hiding this comment.
Not related to this PR, but if we can clean this line too, that would be great.
After GA, the service will start adding model-version. See comment here: https://msazure.visualstudio.com/Cognitive%20Services/_workitems/edit/9479280
Also, after looking at the docs, and passing model-version=2021-05-15, the service didn't fail or anything
| checkEntityTextOffset | ||
| ); | ||
| }); | ||
| // it("family emoji wit skin tone modifier", async function(this: Context) { |
There was a problem hiding this comment.
curious, why did u have to disable these tests?
There was a problem hiding this comment.
They broke recorded browser tests for some reason and we have a post about it on the teams channel: https://teams.microsoft.com/l/message/19:[email protected]/1625003748096?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1625003748096&teamName=Azure%20SDK&channelName=Language%20%E2%80%93%20JS%E2%80%89%EF%BC%86%E2%80%89TS%20%F0%9F%90%B1%E2%80%8D%F0%9F%91%A4&createdTime=1625003748096
I will open a PR shortly to re-open them and investigate the issue further there.
All tests pass now finally so this PR re-record all tests and updates the readme.