[Core] Use ES2017 #15744
Merged
[Core] Use ES2017 #15744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
chradek,
jeremymeng,
witemple-msft and
xirzec
as code owners
ghost
added
the
xirzec
approved these changes
Jun 15, 2021
sdk/core/core-http/tsconfig.json
Outdated
| @@ -3,7 +3,6 @@ | |||
| "compilerOptions": { | |||
| "module": "commonjs", | |||
| "outDir": "dist", | |||
| "target": "es5", | |||
There was a problem hiding this comment.
I think we have to major bump core-http for this, since ServiceClient is extended by generated clients (which could be targeting ES5 still, like Storage)
There was a problem hiding this comment.
Oh yes that went over my head! I reverted the change there for now and I am not really sure if it is worth doing given that we are migrating everyone off core-http in the next semester.
jeremymeng
reviewed
Jun 15, 2021
jeremymeng
approved these changes
Jun 15, 2021
ramya-rao-a
approved these changes
Jun 15, 2021
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
* [Core] Use ES2017 * address feedback * revert core-lro change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15640.
EDIT: I will not update core-http and core-lro in this PR.