Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate docs.ms CI onboarding with docindex #15400

Merged
merged 12 commits into from
May 27, 2021
Merged

Automate docs.ms CI onboarding with docindex #15400

merged 12 commits into from
May 27, 2021

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented May 25, 2021 •
edited
Loading

Successful run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=910706&view=results

Note that this updates package versions and handles supersedence -- MicrosoftDocs/azure-docs-sdk-node@4676796

eng/common changes -- Azure/azure-sdk-tools#1635

@danieljurek
Copy link
Member Author

@weshaggard -- PTAL

@danieljurek danieljurek force-pushed the djurek/docs-ci-onboarding branch from fba6e53 to ed92076 Compare May 26, 2021 05:00
weshaggard
weshaggard approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor comments but I do like this version a lot better. It is more in line with what I was looking for originally where the core of the logic can be applied twice once for preview and once for ga. Nice job.

@danieljurek danieljurek merged commit f250483 into master May 27, 2021
@danieljurek danieljurek deleted the djurek/docs-ci-onboarding branch May 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljurek @weshaggard