Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Samples v2 Migration #15317

Merged
merged 4 commits into from
May 26, 2021
Merged

Chat Samples v2 Migration #15317

merged 4 commits into from
May 26, 2021

Conversation

LuChen-Microsoft
Copy link
Member

Migrate Communication Chat samples from the older samples v1 system to the new samples v2 system.

@ghost ghost added the Communication label May 17, 2021
@LuChen-Microsoft LuChen-Microsoft linked an issue May 17, 2021 that may be closed by this pull request
6 tasks
Copy link
Contributor

@0rland0Wats0n 0rland0Wats0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll approve once the samples aren't skipped anymore since they were not being skipped before.

sdk/communication/communication-chat/package.json Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@
// Licensed under the MIT License.

/**
* Demonstrates how to use the ChatThreadClient to do message operations
* @summary Demonstrates how to use the ChatThreadClient to do message operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @summary Demonstrates how to use the ChatThreadClient to do message operations
* @summary Perform message thread operations using the ChatThreadClient.

@@ -2,7 +2,7 @@
// Licensed under the MIT License.

/**
* Demonstrates how to use the ChatThreadClient to do participant operations
* @summary Demonstrates how to use the ChatThreadClient to do participant operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @summary Demonstrates how to use the ChatThreadClient to do participant operations
* @summary Add, list and remove participants from a ChatClient using the ChatThreadClient.

@@ -2,7 +2,7 @@
// Licensed under the MIT License.

/**
* Demonstrates how to use the ChatClient to do thread operations
* @summary Demonstrates how to use the ChatClient to do thread operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @summary Demonstrates how to use the ChatClient to do thread operations
* @summary Perform thread operations using the ChatClient.

@0rland0Wats0n
Copy link
Contributor

Closes #14466

@0rland0Wats0n 0rland0Wats0n enabled auto-merge (squash) May 26, 2021 21:13
@0rland0Wats0n 0rland0Wats0n merged commit 371af9d into Azure:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[communication] Migrate to Samples Workflow V2
3 participants