[Text Analytics] Better names for assertions #14070
Conversation
ghost
added
the
deyaaeldeen
requested review from
maririos,
mssfang,
suhas92,
iscai-msft and
abhahn
| dataSources: EntityDataSource[]; | ||
| normalizedText?: string; | ||
| } | ||
|
|
||
| // @public (undocumented) | ||
| export interface HealthcareEntityAssertion { | ||
| association?: HealthcareEntityAssociation; |
There was a problem hiding this comment.
EntityAssociation should be good enough, since it is under the HealthcareEntityAssertion. That logic also applies to EntityCertainty and EntityConditionality
There was a problem hiding this comment.
We already use the Healthcare prefix for many types, e.g.:
HealthcareEntityRelation,
HealthcareEntityRelationRole,
HealthcareEntityRelationRoleType
So I think we should be consistent and use the prefix Healthcare.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't necessarily agree. The relations, roles, and types, are in fact specific to Healthcare.
The association, certainty, and conditionally could apply to a general entity. I understand it is not the case now, but it will be good to ask the service team if this concept could ever be applied to other entities/endpoints
There was a problem hiding this comment.
Ok I asked Ashly and he said there could be plans to add assertions for other type of entities in one or two semesters. Based on this, I will remove the Healthcare prefix.
| } | ||
|
|
||
| // @public | ||
| export type HealthcareEntityAssociation = "subject" | "other"; |
There was a problem hiding this comment.
Does JS/TS need to capitalize the first letter, such as "Subject", "Other"?
There was a problem hiding this comment.
I am just following the swagger, does this needs to be fixed in the swagger?
Implements new naming for assertions based on @mssfang suggestions. I am using the prefix Healthcare to conform to the naming for healthcare types. I am also fixing a small issue in the definition for
Certainty(fixed in the swagger Azure/azure-rest-api-specs#13247).