[service-bus] Pass in ProcessErrorArgs to subscribe({ processError }) for extra diagnostics #11927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… distinguish the source of an error, etc...
richardpark-msft
requested review from
bterlson,
chradek,
HarshaNalluru,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
ramya-rao-a
reviewed
Oct 19, 2020
* remove 'session' related error sources, just use 'receive'
ramya-rao-a
reviewed
Oct 19, 2020
ramya-rao-a
reviewed
Oct 19, 2020
ramya-rao-a
reviewed
Oct 20, 2020
ramya-rao-a
reviewed
Oct 20, 2020
ramya-rao-a
approved these changes
Oct 20, 2020
…ver, since neither the types extraction or the api view seems correct.
…rdless of autocomplete being on or not.
…e sense to it since this is internal functionality and that is what 'receive' is meant to cover.
…t an error from being logged and reported to the user if it happened to be an AMQP error. * Removed an unnecessary wrapping of the onMessage handler (cosmetic-ish).
… processError(args; ProcessErrorArgs).
richardpark-msft
changed the title
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
reviewed
Oct 20, 2020
ramya-rao-a
approved these changes
Oct 20, 2020
…so you could use an invalid string value in your test data.
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
processErrorcallback passed toReceiver.subscribeto take aProcessErrorArgswhich gives the user some extra context about where the error originated from (errorSource) and the host and entity path.Near term future work - adding in additional information like the message ID (helpful when trying to correlate settlement failures) and the session ID.
Work remaining:
Fixes #11869