[service-bus] Adding in tracing for receive operations #11810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and receiveMessages).
richardpark-msft
requested review from
chradek,
HarshaNalluru and
ramya-rao-a
as code owners
ghost
added
the
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/servicebus/service-bus/src/diagnostics/instrumentServiceBusMessage.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Harsha Nalluru <[email protected]>
sdk/servicebus/service-bus/src/diagnostics/instrumentServiceBusMessage.ts
Outdated
Show resolved
Hide resolved
* Did not mean to expose the createAndEndProcessingSpan publicly.
…rk-msft/azure-sdk-for-js into richardpark-sb-tracing
HarshaNalluru
approved these changes
Oct 14, 2020
…d for the primary messaging flows. Also, including a link to core-tracing for good measure since it shows a nice example of how to enable tracing and collection.
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…hat was ripe for failing in a flaky way.
|
There was a live test with a hardcoded 2 second time delay in it (if things are "slow" it'll fail for no good reason). I've adjusted the test (it's unrelated to changes in this PR as far as I can tell). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 30, 2020
[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2020-05-01 (Azure#11810) * fix spec * fix prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in tracing for the three receive methods (subscribe, receiveMessages and getMessageIterator) for sessions and non-sessions.
Fixes #11465