Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics Advisor] address some CR feedback to #11593 #11629

Closed
wants to merge 1 commit into from

Conversation

jeremymeng
Copy link
Member

  • Rename *id to just id for get/update/delete methods

  • also shorten *ConfigurationId to *ConfigId

  • Improve README

  • Swagger transform to add ref docs for Metric and Dimension

  • Swagger transform to remove hook prefix from hookId and hookName

  • Replace all *DataFeedSourcePatch types with a mapped type

  • Add missing DataFeed.creator property

  • Use mapped type for input of create*() methods instead of multiple ordered parameters.

  • Replace configuration patch types with mapped types from their full result types.

- Rename `*id` to just id for get/update/delete methods

- also shorten `*ConfigurationId` to `*ConfigId`

- Improve README

- Swagger transform to add ref docs for `Metric` and `Dimension`

- Swagger transform to remove `hook` prefix from `hookId` and `hookName`

- Replace all `*DataFeedSourcePatch` types with a mapped type

- Add missing DataFeed.creator property

- Use mapped type for input of `create*()` methods instead of multiple ordered parameters.

- Replace configuration patch types with mapped types from their full result types.
@jeremymeng jeremymeng closed this Oct 3, 2020
@jeremymeng jeremymeng deleted the address-cr-feedback-1 branch October 3, 2020 16:58
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant