add adfs support in Identity SDK. #11591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
daviwil
reviewed
Oct 1, 2020
| @@ -143,8 +143,9 @@ export class IdentityClient extends ServiceClient implements INetworkModule { | |||
| } | |||
|
|
|||
| try { | |||
| const urlSuffix = tenantId === "adfs" ? "oauth2/token" : "oauth2/v2.0/token"; | |||
There was a problem hiding this comment.
We should definitely pull this out into a helper method now so that we don't have to maintain it in 4 different places.
There was a problem hiding this comment.
moved it as a helper under util
|
Looks good, but address @daviwil's feedback please 🙏 ✨ |
schaabs
approved these changes
Oct 2, 2020
joshfree
added
Client
joshfree
approved these changes
Oct 2, 2020
daviwil
approved these changes
Oct 2, 2020
1 task
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 18, 2020
s360 fixes for Azure DNS (Azure#11591) * s360 fixes for Azure DNS * Additional property * Property fix * Readonly property * CloudError fix * Examples. cloud error * Avocado fix * read.md * Prettier
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 18, 2020
s360 fixes for Azure DNS (Azure#11591) * s360 fixes for Azure DNS * Additional property * Property fix * Readonly property * CloudError fix * Examples. cloud error * Avocado fix * read.md * Prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ADFS authorities to connect to correct endpoint and bypass validation on MSAL for MSAL supported credentials.
Fixes #11323 #10226