Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Fix test failure in the canary region #11588

Merged

Conversation

HarshaNalluru
Copy link
Member

From #11576

image

Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good - nice find!

@ghost
Copy link

ghost commented Oct 1, 2020

Hello @HarshaNalluru!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1992667 into Azure:master Oct 1, 2020
ghost pushed a commit that referenced this pull request Oct 2, 2020
From #11576
![image](https://user-images.githubusercontent.com/10452642/94872905-b18a2b00-0402-11eb-8339-8818586a594a.png)

### Background
We realized the max message size on the link has been increased with #11588.

### Cause
The new test failures were caused since the messages that can be held/sent are have been increased through the new limit, more many messages being sent would mean that we'd receive all of them and verify per the test which would take more time and hence the timeouts.

### Fix in the test
Increase the message size and also create messages based on the maxMessageSize. This brings down the test time and would also be mindful of the potential size increase in the future.
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 11, 2020
Dev containerservice microsoft.container service 2020 11 01 (Azure#11588)

* Adds base for updating Microsoft.ContainerService from version stable/2020-09-01 to version 2020-11-01

* Updates readme

* Updates API version in new specs and examples

* add autoupgradeprofile to 2020-11-01 (Azure#11363)

* add autoupgradeprofile

* add autoupgrader profile to mc

* format change

Co-authored-by: Xiahe Liu <[email protected]>

* add pod subnet id on agentpool (Azure#11310)

* aks: add pod identity profile spec (Azure#11366)

* add private dns zone property in 2020-11-01 (Azure#11311)

Co-authored-by: Li Ma <[email protected]>

* Remove invalid pattern and adjust description (Azure#11312)

* aks: fix pod identity profile field names (Azure#11484)

* aks: add missing `podIdentityProfile.enabled` field

* aks: typo

* add non upgrade channel (Azure#11492)

Co-authored-by: Xiahe Liu <[email protected]>

* Make identityProfile mutable (Azure#11458)

* Add KubeletConfig and LinuxOSConfig specs (Azure#11490)

* aks: update readme tag for 1101 (Azure#11472)

* aks: update readme tag

* aks: add `2020-11-01-only`

* resovle merge conlicts to master, adding recent master change to dev branch (Azure#11604)

Co-authored-by: Xiahe Liu <[email protected]>

Co-authored-by: Xiahe Liu <[email protected]>
Co-authored-by: Paul Miller <[email protected]>
Co-authored-by: hbc <[email protected]>
Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Qingchuan Hao <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Bo Wang <[email protected]>
Co-authored-by: Phoenix He <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants