Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core paging] Update linting scripts and auto linting #11274

Merged
merged 10 commits into from
Sep 23, 2020
18 changes: 18 additions & 0 deletions sdk/core/core-paging/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"plugins": ["@azure/azure-sdk"],
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
// The following rules have to be turned off for this package.
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
"rules": {
// `package.json`'s sideEffects has to be true because this package loads a
// polyfill.
"@azure/azure-sdk/ts-package-json-sideeffects": "off",
// this package does not have a module in `dist` because the directory does
// not exists.
"@azure/azure-sdk/ts-package-json-main-is-cjs": "off",
// this package does not export a module.
"@azure/azure-sdk/ts-package-json-module": "off",
// this package does not create a `dist` directory to be included in `files`
// list in `package.json`.
"@azure/azure-sdk/ts-package-json-files-required": "off"
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
}
}
35 changes: 17 additions & 18 deletions sdk/core/core-paging/package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{
"name": "@azure/core-paging",
"author": {
"name": "Microsoft Corporation",
"email": "[email protected]",
"url": "https://github.com/Azure/azure-sdk-for-js"
},
"author": "Microsoft Corporation",
"sdk-type": "client",
"version": "1.1.3",
"description": "Core types for paging async iterable iterators",
Expand All @@ -14,10 +10,12 @@
],
"keywords": [
"microsoft",
"clientruntime"
"clientruntime",
"azure",
"cloud"
],
"main": "./dist-esm/index.js",
"types": "./types/latest/corePaging.d.ts",
"main": "dist-esm/index.js",
"types": "./types/latest/core-paging.d.ts",
"typesVersions": {
"<3.6": {
"types/latest/*": [
Expand All @@ -28,18 +26,18 @@
"files": [
"types/latest/corePaging.d.ts",
"types/3.1",
"dist-esm/**/*.js",
"LICENSE",
"README.md"
"README.md",
"dist-esm/src"
],
"license": "MIT",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-paging",
"repository": {
"type": "git",
"url": "[email protected]:Azure/azure-sdk-for-js.git"
"engines": {
"node": ">=8.0.0"
},
"license": "MIT",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-paging/README.md",
"repository": "github:Azure/azure-sdk-for-js",
"bugs": {
"url": "http://github.com/Azure/azure-sdk-for-js/issues"
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
},
"scripts": {
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
Expand All @@ -52,8 +50,8 @@
"integration-test:browser": "echo skipped",
"integration-test:node": "echo skipped",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint": "eslint -c ../../.eslintrc.old.json src --ext .ts -f html -o template-lintReport.html || exit 0",
"lint:fix": "eslint \"src/**/*.ts\" -c ../../.eslintrc.old.json --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json src --ext .ts",
"lint:fix": "eslint package.json src --ext .ts --fix --fix-type [problem,suggestion]",
"pack": "npm pack 2>&1",
"prebuild": "npm run clean",
"test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
Expand All @@ -69,6 +67,7 @@
"@azure/core-asynciterator-polyfill": "^1.0.0"
},
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@types/node": "^8.0.0",
"@typescript-eslint/eslint-plugin": "^2.0.0",
"@typescript-eslint/parser": "^2.0.0",
Expand Down
3 changes: 3 additions & 0 deletions sdk/core/core-paging/src/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import "@azure/core-asynciterator-polyfill";