Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core paging] Update linting scripts and auto linting #11274

Merged
merged 10 commits into from
Sep 23, 2020
Merged

[Core paging] Update linting scripts and auto linting #11274

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6ac1de4
[Core paging] Update linting scripts and auto linting
deyaaeldeen Sep 15, 2020
a08e26e
formatting changes
deyaaeldeen Sep 15, 2020
f3782d2
addressing Jeff's comments
deyaaeldeen Sep 20, 2020
a79574d
fixes
deyaaeldeen Sep 20, 2020
100495a
turn sideEffects back on
deyaaeldeen Sep 20, 2020
1810344
adding comments to address Ramya's feedback
deyaaeldeen Sep 20, 2020
1a6c646
a typo
deyaaeldeen Sep 20, 2020
fa4ecad
adding dist-esm/index.js back
deyaaeldeen Sep 20, 2020
1661dac
Update sdk/core/core-paging/.eslintrc.json
deyaaeldeen Sep 22, 2020
c416696
remove dist-esm/src from files in package.json
deyaaeldeen Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sdk/core/core-paging/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
{
"plugins": ["@azure/azure-sdk"],
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
// The following rules have to be turned off for this package.
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
"rules": {
// `package.json`'s sideEffects has to be true because this package loads a
// polyfill.
"@azure/azure-sdk/ts-package-json-sideeffects": "off",
// this package does not have a module in `dist` because the directory does
// not exists.
"@azure/azure-sdk/ts-package-json-main-is-cjs": "off",
// this package does not export a module.
"@azure/azure-sdk/ts-package-json-module": "off",
// this package does not create a `dist` directory to be included in `files`
// list in `package.json`.
"@azure/azure-sdk/ts-package-json-files-required": "off"
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
}
}