[Service Bus] Fix MaxListenersExceededWarning by avoiding adding too many listeners

[HarshaNalluru]

Issue #11154

Cause

The listeners for sender_error, receiver_error were added when the management link is initialized.
managementClient._init is being called for each of the management requests irrespective of the link being active/inactive.
As a result, listeners are being added for each request without cleaning up the older ones and hence blowing up the max limit (10).

Fix

The fix in this PR is to call the _init only if the link is not open. This prevents from adding too many listeners.
(This I feel is the missing part from the refactoring at #10807)

[HarshaNalluru]

/azp run js - servicebus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[richardpark-msft]

Approved with a comment that we probably want to take a look at this (and all locations) to make sure the pattern you've established is properly applied everywhere.

[richardpark-msft]

This fix should work.

I think the issue here is that the two event listeners that are being added should have been passed in as part of the respective options for their links, much like this one is for session error:

azure-sdk-for-js/sdk/servicebus/service-bus/src/core/managementClient.ts

Line 232 in 8fb7f4e

onSessionError: (context: EventContext) => {

(and yes, I totally missed this during my refactor. We can add in some testing for this and possibly a longer term fix as a later PR).

[ramya-rao-a]

@richardpark-msft, Can you log an issue for the said longer term fix or do we want to re-use the existing one?

[HarshaNalluru]

I think the issue here is that the two event listeners that are being added should have been passed in as part of the respective options for their links, much like this one is for session error

Agree with that. I did think in those lines, though didn't spend much time on how. Moreover, initializing the link for each request shouldn't happen even if we tie the listeners and since that fixes the current issue, went ahead just with it.