-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] remove dependency on esm
#28617
Labels
Client
This issue points to a problem in the data-plane of the library.
test-reliability
Issue that causes tests to be unreliable
Milestone
Comments
jeremymeng
added
Client
This issue points to a problem in the data-plane of the library.
test-reliability
Issue that causes tests to be unreliable
labels
Feb 20, 2024
for *.js there's a fix of |
maorleger
added a commit
that referenced
this issue
Mar 12, 2024
Builds off of Matt's work on moving to tsx in #28801 by removing the `use-esm-workaround` flag from packages that needed it before we moved to tsx. There's additional cleanup to be had, but I am trying not to cause a build storm. We are at a point where we can delete `esm` globally! Contributes to #28617 which can be completed with a no-ci change to remove `esm` globally ****NO_CI****
Tasks remaining:
|
maorleger
added a commit
that referenced
this issue
Apr 15, 2024
We no longer use esm4mocha, instead relying on tsx for our node-js-input tests. Now that this has been in place for some time, we can remove esm4mocha followed by the esm dependency. Contributes to #28617
maorleger
added a commit
that referenced
this issue
Apr 17, 2024
### Packages impacted by this PR All via dev-tool ### Issues associated with this PR Contributes to #28617 ### Describe the problem that is addressed by this PR esm is still being required in our test:node-ts-input and I don't believe it is necessary. I'm removing it, but PLEASE do let me know what I'm missing - I don't know much about mocha config to be honest.
Closed via 446e9d8 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Client
This issue points to a problem in the data-plane of the library.
test-reliability
Issue that causes tests to be unreliable
The majority of tests have been switched off
esm
in PR #28589. There are still a few packages that need more attention before they can remove usage ofesm
. Mainly due to the__dirname
usage that is no available in ESM. This issue tracks fixing them.Success Criteria:
--use-esm-workaround=true
option in NPM script removedResults of
npm run integration-test:node
in playback mode is on par withnpm run unit-test:node
azure-sdk-for-js/sdk/cognitivelanguage/ai-language-text/package.json
Line 76 in 6884926
azure-sdk-for-js/sdk/keyvault/keyvault-certificates/package.json
Line 54 in 6884926
azure-sdk-for-js/sdk/keyvault/keyvault-secrets/package.json
Line 55 in 6884926
azure-sdk-for-js/sdk/keyvault/keyvault-admin/package.json
Line 59 in 6884926
azure-sdk-for-js/sdk/keyvault/keyvault-keys/package.json
Line 60 in 6884926
azure-sdk-for-js/sdk/monitor/monitor-opentelemetry/package.json
Line 28 in 6884926
azure-sdk-for-js/sdk/monitor/monitor-opentelemetry-exporter/package.json
Line 28 in 6884926
azure-sdk-for-js/sdk/web-pubsub/web-pubsub-client-protobuf/package.json
Line 36 in 6884926
azure-sdk-for-js/sdk/schemaregistry/schema-registry-avro/package.json
Line 26 in 6884926
azure-sdk-for-js/sdk/eventhub/event-hubs/package.json
Line 55 in 6884926
azure-sdk-for-js/sdk/appconfiguration/app-configuration/package.json
Line 56 in 6884926
The text was updated successfully, but these errors were encountered: