Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUSH] Perf pipelines rush update --full fails #24635

Closed
HarshaNalluru opened this issue Feb 1, 2023 · 4 comments · Fixed by #24636 or #24644
Closed

[RUSH] Perf pipelines rush update --full fails #24635

HarshaNalluru opened this issue Feb 1, 2023 · 4 comments · Fixed by #24636 or #24644
Assignees
@mikeharder @HarshaNalluru
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Milestone
2023-02

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Feb 1, 2023 •
edited
Loading

Pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2152552&view=logs&j=42ded549-05ee-5cdb-7ba7-7a948a0cc056&t=49e32a0b-4245-531b-0723-9d45113ffbd3

image
rush update --full broken by microsoft/rushstack#3937
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 1, 2023
@HarshaNalluru HarshaNalluru added this to the 2023-02 milestone Feb 1, 2023
@HarshaNalluru
Copy link
Member Author

Potential fix - pin "@microsoft/api-extractor": "7.34.0" until rush team advises with some other workaround or a new version with the fix

@HarshaNalluru HarshaNalluru mentioned this issue Feb 1, 2023
Merged
@mikeharder
Copy link
Member

mikeharder commented Feb 1, 2023 •
edited
Loading

This may be a bug in pnpm. For optional peer deps, pnpm does not issue a warning if the dep is completely missing, but it does issue a warning if the dep is present but a non-matching version.

pnpm/pnpm#6013

@mikeharder
Copy link
Member

Another workaround might be to add @types/node to the rush globalPeerDependencyRules settings (https://rushjs.io/pages/configs/pnpm-config_json/).

@mikeharder mikeharder mentioned this issue Feb 1, 2023
Merged
mikeharder added a commit that referenced this issue Feb 1, 2023
@mikeharder
Allow any version of @types/node to satisfy peer dependencies (#24644)
b58e71d 
- Fixes #24635
- Reverts #24636, an earlier fix to #24635
- Adds @types/node to globalPeerDependencyRules.allowAny
- pnpm-config.json was introduced with Rush 5.79.0
  - Settings should be migrated from rush.json to pnpm-config.json
  - Setting "resolutionStrategy" was removed in Rush 5.47.0
HarshaNalluru pushed a commit to HarshaNalluru/azure-sdk-for-js that referenced this issue Feb 1, 2023
@mikeharder @HarshaNalluru
Allow any version of @types/node to satisfy peer dependencies (Azure#…
c3ecca0 
…24644)

- Fixes Azure#24635
- Reverts Azure#24636, an earlier fix to Azure#24635
- Adds @types/node to globalPeerDependencyRules.allowAny
- pnpm-config.json was introduced with Rush 5.79.0
  - Settings should be migrated from rush.json to pnpm-config.json
  - Setting "resolutionStrategy" was removed in Rush 5.47.0
@mikeharder
Copy link
Member

[node-core-library] Moving @types/node to an optional peerDependency causes errors if the version doesn't match
microsoft/rushstack#3946

HarshaNalluru added a commit that referenced this issue Feb 1, 2023
@HarshaNalluru @mikeharder
Allow any version of @types/node to satisfy peer dependencies (#24656)
70aced8 
* Allow any version of @types/node to satisfy peer dependencies (#24644)

- Fixes #24635
- Reverts #24636, an earlier fix to #24635
- Adds @types/node to globalPeerDependencyRules.allowAny
- pnpm-config.json was introduced with Rush 5.79.0
  - Settings should be migrated from rush.json to pnpm-config.json
  - Setting "resolutionStrategy" was removed in Rush 5.47.0

* lock file and artifacts

---------

Co-authored-by: Mike Harder <[email protected]>
jeremymeng pushed a commit to jeremymeng/azure-sdk-for-js that referenced this issue Feb 8, 2023
@HarshaNalluru @mikeharder
Allow any version of @types/node to satisfy peer dependencies (Azure#…
3a12ab1 
…24656)

* Allow any version of @types/node to satisfy peer dependencies (Azure#24644)

- Fixes Azure#24635
- Reverts Azure#24636, an earlier fix to Azure#24635
- Adds @types/node to globalPeerDependencyRules.allowAny
- pnpm-config.json was introduced with Rush 5.79.0
  - Settings should be migrated from rush.json to pnpm-config.json
  - Setting "resolutionStrategy" was removed in Rush 5.47.0

* lock file and artifacts

---------

Co-authored-by: Mike Harder <[email protected]>
EmmaZhu pushed a commit that referenced this issue Feb 24, 2023
@HarshaNalluru @mikeharder @EmmaZhu
Allow any version of @types/node to satisfy peer dependencies (#24656)
33536fe 
* Allow any version of @types/node to satisfy peer dependencies (#24644)

- Fixes #24635
- Reverts #24636, an earlier fix to #24635
- Adds @types/node to globalPeerDependencyRules.allowAny
- pnpm-config.json was introduced with Rush 5.79.0
  - Settings should be migrated from rush.json to pnpm-config.json
  - Setting "resolutionStrategy" was removed in Rush 5.47.0

* lock file and artifacts

---------

Co-authored-by: Mike Harder <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikeharder mikeharder

@HarshaNalluru HarshaNalluru

Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Milestone
2023-02
2 participants
@mikeharder @HarshaNalluru