Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int32 data type is returned for integer-like Double values #19899

Closed
2 of 6 tasks
craxal opened this issue Jan 19, 2022 · 3 comments
Closed
2 of 6 tasks

Int32 data type is returned for integer-like Double values #19899

craxal opened this issue Jan 19, 2022 · 3 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service. Tables

Comments

@craxal
Copy link
Member

craxal commented Jan 19, 2022

  • Package Name: @azure/data-tables
  • Package Version: 13.0.1-alpha.20220112.3
  • Operating system: Windows 11
  • nodejs
    • version: 16.3.1
  • browser
    • name/version:
  • typescript
    • version: 4.5.3
  • Is the bug related to documentation in

Describe the bug
The client library does not return the correct data type for Double entity properties with integer-like values.

To Reproduce
Steps to reproduce the behavior:

  1. Run the following code snippet:
     const client = TableClient.fromConnectionString("<CONNECTION_STRING>, "testmismatch");
     await client.createTable();
     await client.createEntity({ partitionKey: "A", rowKey: "A", value: { value: "6824053932181", type: "Double" } });
     const result = await client.listEntities({ disableTypeConversion: true, requestOptions: {} }).byPage().next();
     if (!!result.done) {
         console.log([]);
     } else {
         console.log(JSON.stringify(result.value, null, 2));
     }
  2. Observe the console output.

Expected behavior
The output should look like the following (note the expected data type for "value":

[
  {
    "etag": "W/\"datetime'2022-01-19T01%3A28%3A35.4155551Z'\"",
    "partitionKey": "A",
    "rowKey": "A",
    "timestamp": "2022-01-19T01:28:35.4155551Z",
    "value": {
      "value": "6824053932181",
      "type": "Double"
    }
  }
]

Instead, the following comes out (note the actual data type for "value", even though the value is clearly outside the range of Int32):

[
  {
    "etag": "W/\"datetime'2022-01-19T01%3A28%3A35.4155551Z'\"",
    "partitionKey": "A",
    "rowKey": "A",
    "timestamp": "2022-01-19T01:28:35.4155551Z",
    "value": {
      "value": "6824053932181",
      "type": "Int32"
    }
  }
]

Screenshots
N/A

Additional context
N/A

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Tables labels Jan 19, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jan 19, 2022
@joheredi joheredi removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jan 21, 2022
@joheredi
Copy link
Member

This problem can be reproduced when the Edm.Double value stored in the service has no decimals for example 123.0

When the SDK retrieves the entity the service doesn’t send odata.type metadata about the type of the property. When parsing the response payload with JavaScript’s native JSON parser the .0 gets lost. So when the SDK gets the chance to work with the data we are no longer able to tell between an Edm.Double with no decimals and an Edm.Int32.

Without the service sending odata.type metadata we don’t have a reliable way in JavaScript to differentiate the types in this scenario.

I'm currently discussing with the Service team alternatives to solve this problem.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Jul 22, 2022
Update readme.python.md (Azure#19899)

* Update readme.python.md

* Update readme.md
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Aug 1, 2022
Compute update folder structure (Azure#19723)

* update folder structure

* small errors and CI check

* [Language Text] Update swagger titles (Azure#19835)

* [Language Text] Update swagger titles

* edits

* address feedback

* Review request for Microsoft.ContainerService to add version 2022-06-01 (Azure#19848)

* Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#19421)

* Add key management service profile of a managed cluster for version 2022-06-01 (Azure#19529)

* Add NetworkPlugin none option to 2022-06-01 (Azure#19510)

* Add NetworkPlugin none option to 2022-06-01

* improve description for none value

* Fix violated rule R4041 for 2022-06-01 managedCluster swagger (Azure#19581)

* remove useless directive

* fix R4041

* GA AKS support for Dedicated Host Group (Azure#19547)

* GA AKS support for Dedicated Host Group

* fit some format minor issue

* add newline in end of files

* Defender updates (Azure#19665)

* Defender updates

* sample

* remove old description

Co-authored-by: Bin Xia <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
Co-authored-by: Jianping Zeng <[email protected]>
Co-authored-by: Or Parnes <[email protected]>

* Update resources.json (Azure#19861)

* Pattts/predictive autoscale 20221001 (Azure#19765)

* Rev Autoscale API from 2021-05-01-preview to 2022-10-01.

* Fix minor swagger issue. Default should be 'false'

* Fix swagger validation error

* Defining a new package 2022-10

* AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition

* Fix require property issue

* Run prettier against autoscale_API.json

* [Maps - Render & Spatial Services] add v2022-08-01 (Azure#19520)

* copy old swagger to new folders

* set api version to 2022-08-01

* apply api changes

Co-authored-by: Gigi Grajo <[email protected]>

* update appconfiguration (Azure#19330)

* update appconfiguration

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* [Hub Generated] Publish private branch 'main' (Azure#19852)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>

* Merging Dynatrace swagger in stable folder (Azure#19862)

* Committing base swagger version

* Removing preview tag from stable folder api version

* Changing version name in all the files

* Updating readme.go and readme.md files

* [CDN] Fix customDomains property type in Endpoint (Azure#19788)

* [CDN] Fix customDomains property type in Endpoint

* Fix linter error

Co-authored-by: Bo Zhang <[email protected]>

* Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (Azure#19866)

* update folders

* [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (Azure#19844)

* Update description of exportable attribute and release_policy.data

* Remove submodule azure-reset-api-specs

* Fix description for exportable

Co-authored-by: Sunny Solanki <[email protected]>

* Add latest StorageMover updates (Azure#19876)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

* Add latest StorageMover updates

Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>

* Update readme.python.md (Azure#19899)

* Update readme.python.md

* Update readme.md

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (Azure#19878)

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review

* Add known words

* Removed static IP allocation only from examples (Azure#19858)

* Removed static IP allocation

* Removed static only from examples

Co-authored-by: Arpit Gagneja <[email protected]>

* Update securityinsights readme.python (Azure#19903)

* update securityinsights readme.python

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* fix lint errors in Synapse trigger.json (Azure#19660)

* put json files into RP folders

* update readme

* Add CONTRIBUTING.md (Azure#19257)

* Add CONTRIBUTING.md

* Apply suggestions from PR review

Co-authored-by: Heath Stewart <[email protected]>

* Apply suggestions from PR review

Co-authored-by: Weidong Xu <[email protected]>

* Regen toc for CONTRIBUTING.md

* Address PR review comments

* Address PR review comments

Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>

* fix devcenter readme.go.md config (Azure#19906)

* fix readme.go.md config

* rename to SkuInfo

* add annotation for labservices (Azure#19884)

* add to description of OS state (Azure#19764)

* [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (Azure#19767)

* Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item

* Update managed hsm private endpoint connection item in mhsm spec for latest api version

* Address LRO_RESPONSE_HEADER violation for managed hsm

Long running operations that are annotated with x-ms-long-running-operation:true
must return location header or azure-AsyncOperation in response.
Added the missing location header for managed hsm update command as well as to the corresponding
examples.

* [Microsoft.DeviceUpdate] Adding first stable API version (Azure#19846)

* Copied the most recent preview version into the first stable version

* Updated api version in new stable version, added the tag to readme.md

* Fixed typo

* Fixed the wrong path in readme.md

* Reverted VS Code automatic breaking change

* Fix broken link (Azure#19688)

* add aadObjectId property to kustoPool (Azure#19856)

Co-authored-by: Amit Elran <[email protected]>

* Updata securityinsights readme.python (Azure#19917)

* update securityinsights readme.python

* update readme.python

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* modify readme.typescripy.md for compute package (Azure#19607)

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* Dev gubalasu frontdoor microsoft.network 2021 06 01 (Azure#19578)

* Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01

* Updates readme

* Updates API version in new specs and examples

* update waf configs and examples from 2020-11-01

* Update api version in new specs and examples

* Migration api update

* Update readme

* Fix readme

* update readme

* Fix readme again

* Fix readme

* Fix readme

* update waf policy provisioning state

* Update securityinsights readme.python (Azure#19923)

* update securityinsights readme.python

* update readme.python

* last modify

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>

* sync with changes made to master

* update folder structure

* small errors and CI check

* update folders

* put json files into RP folders

* update readme

* resolve capitalization and number misplacement accident

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: FumingZhang <[email protected]>
Co-authored-by: Bin Xia <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
Co-authored-by: Jianping Zeng <[email protected]>
Co-authored-by: Or Parnes <[email protected]>
Co-authored-by: Alexander Batishchev <[email protected]>
Co-authored-by: PatrickTseng <[email protected]>
Co-authored-by: gigi <[email protected]>
Co-authored-by: Gigi Grajo <[email protected]>
Co-authored-by: zhenbiao wei <[email protected]>
Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Abhishek Krishna <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>
Co-authored-by: Divyansh Agarwal <[email protected]>
Co-authored-by: t-bzhan <[email protected]>
Co-authored-by: Bo Zhang <[email protected]>
Co-authored-by: Uriel Cohen <[email protected]>
Co-authored-by: susolank <[email protected]>
Co-authored-by: Sunny Solanki <[email protected]>
Co-authored-by: Ralf Beckers <[email protected]>
Co-authored-by: arpit-gagneja <[email protected]>
Co-authored-by: Arpit Gagneja <[email protected]>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Co-authored-by: YanjunGao <[email protected]>
Co-authored-by: Mike Kistler <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Jiahui Peng <[email protected]>
Co-authored-by: j-zhong-ms <[email protected]>
Co-authored-by: Tom FitzMacken <[email protected]>
Co-authored-by: neeerajaakula <[email protected]>
Co-authored-by: darkoa-msft <[email protected]>
Co-authored-by: Roy Wellington <[email protected]>
Co-authored-by: Amit Elran <[email protected]>
Co-authored-by: Amit Elran <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Co-authored-by: gubalasu <[email protected]>
@xirzec xirzec added the Service This issue points to a problem in the service. label Mar 31, 2023
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 31, 2023
@xirzec xirzec added bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Mar 31, 2023
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 31, 2023
@ghost
Copy link

ghost commented Mar 31, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @klaaslanghout.

Issue Details
  • Package Name: @azure/data-tables
  • Package Version: 13.0.1-alpha.20220112.3
  • Operating system: Windows 11
  • nodejs
    • version: 16.3.1
  • browser
    • name/version:
  • typescript
    • version: 4.5.3
  • Is the bug related to documentation in

Describe the bug
The client library does not return the correct data type for Double entity properties with integer-like values.

To Reproduce
Steps to reproduce the behavior:

  1. Run the following code snippet:
     const client = TableClient.fromConnectionString("<CONNECTION_STRING>, "testmismatch");
     await client.createTable();
     await client.createEntity({ partitionKey: "A", rowKey: "A", value: { value: "6824053932181", type: "Double" } });
     const result = await client.listEntities({ disableTypeConversion: true, requestOptions: {} }).byPage().next();
     if (!!result.done) {
         console.log([]);
     } else {
         console.log(JSON.stringify(result.value, null, 2));
     }
  2. Observe the console output.

Expected behavior
The output should look like the following (note the expected data type for "value":

[
  {
    "etag": "W/\"datetime'2022-01-19T01%3A28%3A35.4155551Z'\"",
    "partitionKey": "A",
    "rowKey": "A",
    "timestamp": "2022-01-19T01:28:35.4155551Z",
    "value": {
      "value": "6824053932181",
      "type": "Double"
    }
  }
]

Instead, the following comes out (note the actual data type for "value", even though the value is clearly outside the range of Int32):

[
  {
    "etag": "W/\"datetime'2022-01-19T01%3A28%3A35.4155551Z'\"",
    "partitionKey": "A",
    "rowKey": "A",
    "timestamp": "2022-01-19T01:28:35.4155551Z",
    "value": {
      "value": "6824053932181",
      "type": "Int32"
    }
  }
]

Screenshots
N/A

Additional context
N/A

Author: craxal
Assignees: joheredi
Labels:

bug, customer-reported, Client, Service Attention, Tables, Service

Milestone: -

Copy link

Hi @craxal, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service. Tables
Projects
None yet
Development

No branches or pull requests

4 participants