Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Recorder] Unify RecordingHttpClient for both node and browser #17014

Closed
HarshaNalluru opened this issue Aug 20, 2021 · 1 comment
Closed
Assignees
Labels
test-utils-recorder Label for the issues related to the common recorder

Comments

@HarshaNalluru
Copy link
Member

At 84d204e, there are two clients with some common code.
Refactor both the clients and remove any duplication

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 20, 2021
@HarshaNalluru HarshaNalluru self-assigned this Aug 20, 2021
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Aug 20, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 20, 2021
@HarshaNalluru HarshaNalluru added this to the [2021] September milestone Aug 20, 2021
@HarshaNalluru
Copy link
Member Author

Solved by 1ff021a

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 4, 2022
Fixing S360 issues (Azure#17014)

* Fixing S360 issues

* Fix style
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 5, 2022
Fixing S360 issues (Azure#17014)

* Fixing S360 issues

* Fix style
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Development

No branches or pull requests

1 participant