-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Align with samples in other languages #14435
Comments
@maorleger recently updated the JavaScript samples. He specifically added AzureIdentityExamples.md, which covers many of the sample cases in other languages. .Net has samples in a different way. Here's a list of the topics that .Net shows in samples, and how many of them we have currently covered:
Based on this, I'll be adding different sets of documentation samples on both v1 and v2.
|
Moved to the July Milestone |
In this PR we're aligning the samples of Identity with other languages. The samples I'm adding in this PR are: - Rolling certificates with ClientCertificateCredential ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/ClientCertificateCredentialSamples.md#rolling-certificates)). - ClientCertificateCredential with a Key Vault Certificate ([Python](Azure/azure-sdk-for-python#18109)) (decided not to use `@azure/keyvault-certificates` because of the possible issues converting certificates from one format to another in Node). - Custom credentials ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#defining-custom-credential-types)). - Using MSAL directly ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-msal-directly)). - On Behalf Of Flow ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-the-on-behalf-of-flow)). New samples related to the v2-specific features will be added after the Identity package is separated. Related to #14435 --- I’ve decided to use this opportunity to: Fix #15324 This PR also implicitly: Fixes #15573
We’ve merged the v1 samples. For the v2 samples, let’s work on them next month, while we work on the user studies. |
TODO There’s another sample we’re missing:
|
Other languages have specific samples that show recent features that we are currently adding to Identity, so we don't have these samples yet in our repo.
One place to look for is on the .Net samples folder: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/identity/Azure.Identity
This is related to: #13788
The text was updated successfully, but these errors were encountered: