Express being brought in a dependency #13103
Assignees
Labels
Azure.Identity
Client
This issue points to a problem in the data-plane of the library.
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
needs-team-attention
Workflow: This issue needs attention from Azure service team or SDK team
question
The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Comments
ghost
added
needs-triage
ramya-rao-a
added
Azure.Identity
Client
ghost
removed
the
needs-triage
ghost
added
the
needs-team-attention
|
Thanks for the feedback. I've filed #13465 to track a few ways we can address this issue. |
sophiajt
removed
the
needs-team-attention
ghost
added
the
needs-team-attention
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this issue
Mar 4, 2021
Network november release (Azure#13224) * Adds base for updating Microsoft.Network from version stable/2020-08-01 to version 2020-11-01 * Updates readme * Updates API version in new specs and examples * No snat firewall policy (Azure#12505) * Adding No SNAT feature support to firewall policy * committing prettier-fix * adding period at end of description to prevent failure for checks * Insights on Firewall Policy (Azure#12509) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) * resolving conflicts * resolving conflicts * new api version * resolving conflicts * fixing network validation * running prettier * fixing network valdiation * fixing network valdiation Co-authored-by: Mikhail <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> * Firewall Policy Insights with region (Azure#12711) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) * resolving conflicts * resolving conflicts * new api version * resolving conflicts * fixing network validation * running prettier * fixing network valdiation * fixing network valdiation * Passing in the regions to backend * changed the reference definition Co-authored-by: Mikhail <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> * Support for Listing IKE Security Associations for VPN Link Connections (Azure#12305) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) * Adding getikesas for vpn link connections * pretty fix * Naming * Update VpnSiteLinkConnectionGetIkeSas.json * Update VpnSiteLinkConnectionGetIkeSas.json * Changing API version * Update readme.md * Updating API version * Removing changes from older API * Update virtualWan.json Co-authored-by: Mikhail <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> * Added 'Subnet' property to LoadBalancerBackendAddress (Azure#12625) * Support for ResetConnection for VNG and VPN Link connections (Azure#12715) * fix the name mismatch (Azure#12826) * Add support for Traffic selector param in VpnConnection for virtualWan (Azure#12903) * Add support for Traffic selector param in Connection - initial changes * Add trafficSelectorPolicies list in responses * Add trafficSelectorPolicies list in Get and List connection * cleanup stostools (Azure#12699) * Revert "Merge branch 'network-november-release' into ak-traffic-selector" This reverts commit 1a8f61e3c4395f410d6ff16ee41da4d2eeb091b5, reversing changes made to 3c90ff8ccb6c1e46c0480643906d6b5c5388e8c8. Co-authored-by: Zhenglai Zhang <[email protected]> * Revert "Add support for Traffic selector param in VpnConnection for virtualWan" (Azure#13088) * Revert "Add support for Traffic selector param in VpnConnection for virtualWan (Azure#12903)" This reverts commit 34dcf04f0ee453fa739ec2f790376a8decb5a3ab. * cleanup stostools (Azure#12699) Co-authored-by: Zhenglai Zhang <[email protected]> * Re - Add support for Traffic selector param in VpnConnection for virtualWan (Azure#13103) * Add support for Traffic selector param in Connection - initial changes * Add trafficSelectorPolicies list in responses * Add trafficSelectorPolicies list in Get and List connection * add auth type property to vng config (Azure#13183) * added reverted by mistake api version * fixed mistyping * Fix name mismatch for virtual network local gateway (Azure#13266) * fix the name mismatch * fix name mismatch in nov Co-authored-by: nikhilpadhye1 <[email protected]> Co-authored-by: Sai Sujith Reddy Mankala <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: Akshat Kale <[email protected]> Co-authored-by: litchiyangMSFT <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: neethirshetty <[email protected]>
|
Update: We have removed the dependency on express in #14521 and the version 1.2.5 of the Thanks for reporting @chattersley! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We are getting an error webpacking with the latest @azure/identity release, 1.2.0. It is dependent upon express. If it is not already included you get an error "Module not found: Error: Can't resolve 'express' in '...\node_modules@azure\identity\dist-esm\src\credentials'". If you include it the overall built artefact size gets increased by +10MB!!! We are using this to build serverless artefacts, e.g. Azure Function Apps so this has a huge impact on us.
Express is referenced in interactiveBrowserCredential.ts.
This was brought in by the commit cce70bb.
It is even referenced in the package.json as a development dependency. Can this be removed in the future as this significantly impacts built artefacts.
The text was updated successfully, but these errors were encountered: