Update template to depend on core-http (#4437)

- Bundle core-http instead of requiring as external
Azure · Jul 29, 2019 · e0c8e19 · e0c8e19
1 parent 8aad5be
commit e0c8e19
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 18 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/template/template/package.json b/sdk/template/template/package.json
@@ -60,7 +60,7 @@
   "sideEffects": false,
   "private": true,
   "dependencies": {
-    "@azure/ms-rest-js": "^1.8.1",
+    "@azure/core-http": "1.0.0-preview.2",
     "events": "^3.0.0",
     "tslib": "^1.9.3"
   },

diff --git a/sdk/template/template/review/template.api.md b/sdk/template/template/review/template.api.md
@@ -5,7 +5,7 @@
 ```ts
 
 import EventEmitter from 'events';
-import { URLBuilder } from '@azure/ms-rest-js';
+import { URLBuilder } from '@azure/core-http';
 
 // @public (undocumented)
 export function createEventEmitter(): EventEmitter;

diff --git a/sdk/template/template/rollup.base.config.js b/sdk/template/template/rollup.base.config.js
@@ -58,13 +58,12 @@ export function nodeConfig(test = false) {
 export function browserConfig(test = false, production = false) {
   const baseConfig = {
     input: input,
-    external: ["@azure/ms-rest-js"],
     output: {
       file: "browser/azure-template.js",
       format: "umd",
       name: "ExampleClient",
       sourcemap: true,
-      globals: { "@azure/ms-rest-js": "msRest" }
+      globals: { "@azure/core-http": "Azure.Core.HTTP" }
     },
     preserveSymlinks: false,
     plugins: [

diff --git a/sdk/template/template/src/index.ts b/sdk/template/template/src/index.ts
@@ -7,10 +7,10 @@ export { print };
 
 // this is a utility function from a library that should be external
 // for both node and web
-import { isNode } from "@azure/ms-rest-js";
+import { isNode } from "@azure/core-http";
 
 // exporting some value from a dependency
-export { URLBuilder } from "@azure/ms-rest-js";
+export { URLBuilder } from "@azure/core-http";
 
 export function createEventEmitter() {
   // use event emitter