Skip to content

Commit

Permalink
[Perf] Console.logs that are part of the test are not being propagated (
Browse files Browse the repository at this point in the history
#24519)

* Update sdk/test-utils/perf/src/multicore.ts

* changelog
  • Loading branch information
HarshaNalluru authored Jan 23, 2023
1 parent 5138ba6 commit 454612c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
8 changes: 7 additions & 1 deletion sdk/test-utils/perf/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,20 @@

## 1.0.0 (Unreleased)

### 2023-01-18

- [#24518](https://github.com/Azure/azure-sdk-for-js/issues/24518) Fixes the issue where the `console.logs` that are part of the test are not being propagated as expected from the child process(test instance).

[#23819](https://github.com/Azure/azure-sdk-for-js/pull/23819)

### 2022-02-04

- [#19920](https://github.com/Azure/azure-sdk-for-js/pull/19920) Added support for adding polices as part of the client options with the new "additionalPolicies" array.
By leveraging this new option, `configureClientOptions` method is added to the `PerfTest`.

[#20175](https://github.com/Azure/azure-sdk-for-js/pull/20175)

- With the support from the new `PerfTest#configureClientOptions` method, we no longer need the `PerfTest#configureClient` that used to access the private "pipeline" object internal to the client to add/modify the policies.
- With the support from the new `PerfTest#configureClientOptions` method, we no longer need the `PerfTest#configureClient` that used to access the private "pipeline" object internal to the client to add/modify the policies.
- [#20175](https://github.com/Azure/azure-sdk-for-js/pull/20175) removes the `PerfTest#configureClient` along with the new addition.

### 2021-11-24
Expand Down
3 changes: 2 additions & 1 deletion sdk/test-utils/perf/src/multicore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ const createChildProcess = (data: WorkerData): WorkerLike =>
[JSON.stringify(data)],
{
// Configure an IPC channel so that messages can be sent via process.send.
stdio: [0, 0, 0, "ipc"],
// https://nodejs.org/api/child_process.html#optionsstdio
stdio: ["inherit", "inherit", "inherit", "ipc"],
}
);

Expand Down

0 comments on commit 454612c

Please sign in to comment.