[ai] Precise Typechecking

sdk/ai/ai-inference-rest/eslint.config.mjs

@@ -4,13 +4,14 @@ export default azsdkEslint.config([
   {
     rules: {
       "@azure/azure-sdk/ts-modules-only-named": "warn",
-      "@azure/azure-sdk/ts-apiextractor-json-types": "warn",
-      "@azure/azure-sdk/ts-package-json-types": "warn",
-      "@azure/azure-sdk/ts-package-json-engine-is-present": "warn",
-      "tsdoc/syntax": "warn",
-      "@azure/azure-sdk/ts-package-json-module": "off",
-      "@azure/azure-sdk/ts-package-json-files-required": "off",
-      "@azure/azure-sdk/ts-package-json-main-is-cjs": "off",
+    }
+  },
+  {
+    files: ["**/*.ts", "**/*.cts", "**/*.mts"],
+    languageOptions: {
+      parserOptions: {
+        project: ["./tsconfig.test.json"],
+      },
     },
   },
 ]);

sdk/ai/ai-inference-rest/package.json

@@ -38,7 +38,8 @@
       "browser",
       "react-native"
     ],
-    "selfLink": false
+    "selfLink": false,
+    "project": "./tsconfig.src.json"
   },
   "type": "module",
   "files": [
@@ -94,7 +95,11 @@
     "@azure/dev-tool": "^1.0.0",
     "@azure/eslint-plugin-azure-sdk": "^3.0.0",
     "@azure/identity": "^4.3.0",
+    "@azure/monitor-opentelemetry-exporter": "1.0.0-beta.27",
+    "@opentelemetry/instrumentation": "0.56.0",
+    "@azure/opentelemetry-instrumentation-azure-sdk": "1.0.0-beta.7",
     "@opentelemetry/api": "^1.9.0",
+    "@opentelemetry/sdk-trace-node": "1.29.0",
     "@types/node": "^18.0.0",
     "@vitest/browser": "^2.0.5",
     "@vitest/coverage-istanbul": "^2.0.5",

sdk/ai/ai-inference-rest/src/tracingHelper.ts

@@ -18,7 +18,7 @@ import { isError } from "@azure/core-util";
 import type { PipelineRequest, PipelineResponse } from "@azure/core-rest-pipeline";
 
 const INFERENCE_GEN_AI_SYSTEM_NAME = "az.ai.inference";
-const isContentRecordingEnabled = () =>
+const isContentRecordingEnabled = (): boolean =>
   envVarToBoolean("AZURE_TRACING_GEN_AI_CONTENT_RECORDING_ENABLED");
 
 enum TracingAttributesEnum {

sdk/ai/ai-inference-rest/test/public/browser/streamingChat.spec.ts

@@ -54,7 +54,6 @@ describe("chat test suite", () => {
       const reader = (readableStream as any).getReader();
       const buffers: Uint8Array[] = [];
       try {
-        // eslint-disable-next-line no-constant-condition
         while (true) {
           const { value, done } = await reader.read();
           if (done) {

sdk/ai/ai-inference-rest/test/public/node/imageChat.spec.ts

@@ -18,7 +18,7 @@ function getImageDataUrl(imageFile: string, imageFormat: string): string {
   } catch (error) {
     console.error(`Could not read '${imageFile}'.`);
     console.error("Set the correct path to the image file before running this sample.");
-    process.exit(1);
+    throw error;
   }
 }
 

sdk/ai/ai-inference-rest/test/public/tracing.spec.ts

@@ -57,7 +57,7 @@ describe("tracing test suite", () => {
     return `The temperature in ${location} is 72 degrees ${unit}`;
   };
 
-  const updateToolCalls = (toolCallArray: Array<any>, functionArray: Array<any>) => {
+  const updateToolCalls = (toolCallArray: Array<any>, functionArray: Array<any>): void => {
     const dummyFunction = { name: "", arguments: "", id: "" };
     while (functionArray.length < toolCallArray.length) {
       functionArray.push(dummyFunction);
@@ -78,7 +78,14 @@ describe("tracing test suite", () => {
     }
   };
 
-  const handleToolCalls = (functionArray: Array<any>) => {
+  const handleToolCalls = (
+    functionArray: Array<any>,
+  ): {
+    role: string;
+    content: string;
+    tool_call_id: any;
+    name: any;
+  }[] => {
     const messageArray = [];
     for (const func of functionArray) {
       const funcArgs = JSON.parse(func.arguments);

sdk/ai/ai-inference-rest/tsconfig.browser.config.json

@@ -1,10 +1,3 @@
 {
-  "extends": "./.tshy/build.json",
-  "include": ["./src/**/*.ts", "./src/**/*.mts", "./test/**/*.spec.ts"],
-  "exclude": ["./test/**/node/**/*.ts"],
-  "compilerOptions": {
-    "outDir": "./dist-test/browser",
-    "rootDir": ".",
-    "skipLibCheck": true
-  }
+  "extends": ["./tsconfig.test.json", "../../../tsconfig.browser.base.json"]
 }

sdk/ai/ai-inference-rest/tsconfig.json

@@ -1,11 +1,9 @@
 {
   "extends": "../../../tsconfig",
-  "compilerOptions": {
-    "paths": { "@azure-rest/ai-inference": ["./src/index"] },
-    "module": "NodeNext",
-    "moduleResolution": "NodeNext",
-    "rootDir": "."
-  },
-  "ts-node": { "esm": true },
-  "include": ["./src/**/*.ts", "test/**/*.ts", "./test/**/*.ts", "samples-dev/**/*.ts"]
+  "references": [
+    { "path": "./tsconfig.src.json" },
+    { "path": "./tsconfig.samples.json" },
+    { "path": "./tsconfig.test.json" }
+  ],
+  "files": []
 }

sdk/ai/ai-inference-rest/tsconfig.samples.json

@@ -0,0 +1,9 @@
+{
+  "extends": "../../../tsconfig.samples.base.json",
+  "compilerOptions": {
+    "paths": {
+      "@azure-rest/ai-inference": ["./dist/esm"]
+    },
+    "lib": ["DOM"]
+  }
+}

sdk/ai/ai-inference-rest/tsconfig.src.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../../tsconfig.lib.json"
+}

sdk/ai/ai-inference-rest/tsconfig.test.json

@@ -0,0 +1,3 @@
+{
+  "extends": ["./tsconfig.src.json", "../../../tsconfig.test.base.json"]
+}

sdk/ai/ai-inference-rest/vitest.config.ts

@@ -9,7 +9,12 @@ export default mergeConfig(
   defineConfig({
     test: {
       testTimeout: 50000,
-      include: ["test/internal/**/*.spec.ts", "test/public/**/*.spec.ts"],
+      include: ["test/**/*.spec.ts"],
+      typecheck: {
+        enabled: true,
+        tsconfig: "tsconfig.test.json",
+        include: ["test/**/*.ts", "test/**/*.mts", "test/**/*.cts"],
+      },
     },
   }),
 );

sdk/ai/ai-inference-rest/vitest.esm.config.ts

@@ -0,0 +1,11 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { mergeConfig } from "vitest/config";
+import vitestConfig from "./vitest.config.ts";
+import vitestEsmConfig from "../../../vitest.esm.shared.config.ts";
+
+export default mergeConfig(
+  vitestConfig,
+  vitestEsmConfig
+);

sdk/cognitivelanguage/ai-language-conversations/eslint.config.mjs

@@ -0,0 +1,12 @@
+import azsdkEslint from "@azure/eslint-plugin-azure-sdk";
+
+export default azsdkEslint.config([
+  {
+    files: ["**/*.ts", "**/*.cts", "**/*.mts"],
+    languageOptions: {
+      parserOptions: {
+        project: ["./tsconfig.test.json"],
+      },
+    },
+  },
+]);

sdk/cognitivelanguage/ai-language-conversations/package.json

@@ -69,7 +69,7 @@
     "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
     "integration-test:browser": "npm run clean && dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser",
-    "integration-test:node": "dev-tool run test:vitest",
+    "integration-test:node": "dev-tool run test:vitest --esm",
     "lint": "eslint package.json api-extractor.json src test",
     "lint:fix": "eslint package.json api-extractor.json src test --fix --fix-type [problem,suggestion]",
     "pack": "npm pack 2>&1",
@@ -115,7 +115,8 @@
       "browser",
       "react-native"
     ],
-    "selfLink": false
+    "selfLink": false,
+    "project": "./tsconfig.src.json"
   },
   "browser": "./dist/browser/index.js",
   "exports": {

sdk/cognitivelanguage/ai-language-conversations/test/public/utils/recordedClient.ts

@@ -3,7 +3,7 @@
 
 import type { ConversationAnalysisOptions } from "../../../src/index.js";
 import { ConversationAnalysisClient } from "../../../src/index.js";
-import type { RecorderStartOptions } from "@azure-tools/test-recorder";
+import type { RecorderStartOptions, TestInfo } from "@azure-tools/test-recorder";
 import { Recorder, assertEnvironmentVariable } from "@azure-tools/test-recorder";
 import { AzureKeyCredential } from "@azure/core-auth";
 import { createTestCredential } from "@azure-tools/test-credential";
@@ -64,7 +64,7 @@ export function createClient(options: {
  * Should be called first in the test suite to make sure environment variables are
  * read before they are being used.
  */
-export async function startRecorder(currentTest?: Test): Promise<Recorder> {
+export async function startRecorder(currentTest?: TestInfo): Promise<Recorder> {
   const recorder = new Recorder(currentTest);
   await recorder.start(recorderStartOptions);
   await recorder.setMatcher("CustomDefaultMatcher", { excludedHeaders: ["Accept-Language"] });

sdk/cognitivelanguage/ai-language-conversations/tsconfig.browser.config.json

@@ -1,10 +1,3 @@
 {
-  "extends": "./.tshy/build.json",
-  "include": ["./src/**/*.ts", "./src/**/*.mts", "./test/**/*.spec.ts", "./test/**/*.mts"],
-  "exclude": ["./test/**/node/**/*.ts"],
-  "compilerOptions": {
-    "outDir": "./dist-test/browser",
-    "rootDir": ".",
-    "skipLibCheck": true
-  }
+  "extends": ["./tsconfig.test.json", "../../../tsconfig.browser.base.json"]
 }

sdk/cognitivelanguage/ai-language-conversations/tsconfig.json

@@ -1,20 +1,9 @@
 {
   "extends": "../../../tsconfig",
-  "compilerOptions": {
-    "paths": {
-      "@azure/ai-language-conversations": ["./src/index"]
-    },
-    "module": "NodeNext",
-    "moduleResolution": "NodeNext",
-    "rootDir": "."
-  },
-  "include": [
-    "src/**/*.ts",
-    "src/**/*.mts",
-    "src/**/*.cts",
-    "samples-dev/**/*.ts",
-    "test/**/*.ts",
-    "test/**/*.mts",
-    "test/**/*.cts"
-  ]
+  "references": [
+    { "path": "./tsconfig.src.json" },
+    { "path": "./tsconfig.samples.json" },
+    { "path": "./tsconfig.test.json" }
+  ],
+  "files": []
 }

sdk/cognitivelanguage/ai-language-conversations/tsconfig.samples.json

@@ -0,0 +1,8 @@
+{
+  "extends": "../../../tsconfig.samples.base.json",
+  "compilerOptions": {
+    "paths": {
+      "@azure/ai-language-conversations": ["./dist/esm"]
+    }
+  }
+}

sdk/cognitivelanguage/ai-language-conversations/tsconfig.src.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../../tsconfig.lib.json"
+}

sdk/cognitivelanguage/ai-language-conversations/tsconfig.test.json

@@ -0,0 +1,3 @@
+{
+  "extends": ["./tsconfig.src.json", "../../../tsconfig.test.base.json"]
+}

sdk/cognitivelanguage/ai-language-conversations/vitest.config.ts

@@ -11,6 +11,11 @@ export default mergeConfig(
       include: ["test/**/*.spec.ts"],
       hookTimeout: 5000000,
       testTimeout: 5000000,
+      typecheck: {
+        enabled: true,
+        tsconfig: "tsconfig.test.json",
+        include: ["test/**/*.ts", "test/**/*.mts", "test/**/*.cts"],
+      },
     },
   }),
 );

sdk/cognitivelanguage/ai-language-conversations/vitest.esm.config.ts

@@ -0,0 +1,11 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { mergeConfig } from "vitest/config";
+import vitestConfig from "./vitest.config.ts";
+import vitestEsmConfig from "../../../vitest.esm.shared.config.ts";
+
+export default mergeConfig(
+  vitestConfig,
+  vitestEsmConfig
+);

sdk/cognitivelanguage/ai-language-text/eslint.config.mjs

@@ -0,0 +1,12 @@
+import azsdkEslint from "@azure/eslint-plugin-azure-sdk";
+
+export default azsdkEslint.config([
+  {
+    files: ["**/*.ts", "**/*.cts", "**/*.mts"],
+    languageOptions: {
+      parserOptions: {
+        project: ["./tsconfig.test.json"],
+      },
+    },
+  },
+]);

sdk/cognitivelanguage/ai-language-text/package.json

@@ -71,7 +71,7 @@
     "generate:client": "autorest --typescript swagger/README.md",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
     "integration-test:browser": "npm run clean && dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser",
-    "integration-test:node": "dev-tool run test:vitest",
+    "integration-test:node": "dev-tool run test:vitest --esm",
     "lint": "eslint package.json api-extractor.json src test",
     "lint:fix": "eslint package.json api-extractor.json src test --fix --fix-type [problem,suggestion]",
     "pack": "npm pack 2>&1",
@@ -132,7 +132,8 @@
       "browser",
       "react-native"
     ],
-    "selfLink": false
+    "selfLink": false,
+    "project": "./tsconfig.src.json"
   },
   "browser": "./dist/browser/index.js",
   "exports": {

sdk/cognitivelanguage/ai-language-text/tsconfig.browser.config.json

@@ -1,10 +1,3 @@
 {
-  "extends": "./.tshy/build.json",
-  "include": ["./src/**/*.ts", "./src/**/*.mts", "./test/**/*.spec.ts", "./test/**/*.mts"],
-  "exclude": ["./test/**/node/**/*.ts"],
-  "compilerOptions": {
-    "outDir": "./dist-test/browser",
-    "rootDir": ".",
-    "skipLibCheck": true
-  }
+  "extends": ["./tsconfig.test.json", "../../../tsconfig.browser.base.json"]
 }

sdk/cognitivelanguage/ai-language-text/tsconfig.json

@@ -1,20 +1,9 @@
 {
   "extends": "../../../tsconfig",
-  "compilerOptions": {
-    "paths": {
-      "@azure/ai-language-text": ["./src/index"]
-    },
-    "module": "NodeNext",
-    "moduleResolution": "NodeNext",
-    "rootDir": "."
-  },
-  "include": [
-    "src/**/*.ts",
-    "src/**/*.mts",
-    "src/**/*.cts",
-    "samples-dev/**/*.ts",
-    "test/**/*.ts",
-    "test/**/*.mts",
-    "test/**/*.cts"
-  ]
+  "references": [
+    { "path": "./tsconfig.src.json" },
+    { "path": "./tsconfig.samples.json" },
+    { "path": "./tsconfig.test.json" }
+  ],
+  "files": []
 }

sdk/cognitivelanguage/ai-language-text/tsconfig.samples.json

@@ -0,0 +1,8 @@
+{
+  "extends": "../../../tsconfig.samples.base.json",
+  "compilerOptions": {
+    "paths": {
+      "@azure/ai-language-text": ["./dist/esm"]
+    }
+  }
+}

sdk/cognitivelanguage/ai-language-text/tsconfig.src.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../../tsconfig.lib.json"
+}

sdk/cognitivelanguage/ai-language-text/tsconfig.test.json

@@ -0,0 +1,3 @@
+{
+  "extends": ["./tsconfig.src.json", "../../../tsconfig.test.base.json"]
+}

sdk/cognitivelanguage/ai-language-text/vitest.config.ts

@@ -11,6 +11,11 @@ export default mergeConfig(
       include: ["test/**/*.spec.ts"],
       hookTimeout: 5000000,
       testTimeout: 5000000,
+      typecheck: {
+        enabled: true,
+        tsconfig: "tsconfig.test.json",
+        include: ["test/**/*.ts", "test/**/*.mts", "test/**/*.cts"],
+      },
     },
   }),
 );