Fix UnsupportedOperationException when Block download and add test #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
gapra-msft,
jaschrep-msft,
rickle-msft and
sima-zhu
as code owners
vhvb1989
force-pushed
the
fix/#5236/Adding-uploadFromFile-tests
branch
2 times, most recently
from
623b9ab to
fa547fb
Compare
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobClient.java
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobClient.java
Outdated
Show resolved
Hide resolved
vhvb1989
force-pushed
the
fix/#5236/Adding-uploadFromFile-tests
branch
from
fa547fb to
3a47e58
Compare
alzimmermsft
approved these changes
Sep 19, 2019
vhvb1989
force-pushed
the
fix/#5236/Adding-uploadFromFile-tests
branch
3 times, most recently
from
c00499d to
eb96907
Compare
vhvb1989
force-pushed
the
fix/#5236/Adding-uploadFromFile-tests
branch
from
eb96907 to
1b6d477
Compare
alzimmermsft
approved these changes
Sep 20, 2019
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobAPITest.groovy
Outdated
Show resolved
Hide resolved
vhvb1989
force-pushed
the
fix/#5236/Adding-uploadFromFile-tests
branch
from
1b6d477 to
3a5b858
Compare
vhvb1989
force-pushed
the
fix/#5236/Adding-uploadFromFile-tests
branch
from
3a5b858 to
edc745d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteBufferstreamed from the underlying Flux has a null hb.If we want to continue just using ByteBuffer directly this is fixable by using
FluxUtil.byteBufferToArray(bf)which will allocate an array from byteBuffet for heap and non-heap buffers