Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set tier on upload/copy; Rehydrate Priority #5229

Merged
merged 12 commits into from
Sep 9, 2019
Merged

Set tier on upload/copy; Rehydrate Priority #5229

merged 12 commits into from
Sep 9, 2019

Conversation

jaschrep-msft
Copy link
Member

No description provided.

@jaschrep-msft jaschrep-msft added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Sep 3, 2019
alzimmermsft
alzimmermsft requested changes Sep 4, 2019
View reviewed changes
Copy link
Member

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new parameters set query string parameters or are they headers? If they are query string parameters we should re-record the tests that use these methods.

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlockBlobAsyncClient.java Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlockBlobAsyncClient.java Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlockBlobAsyncClient.java Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlockBlobAsyncClient.java Show resolved Hide resolved
@jaschrep-msft
Copy link
Member Author

Uploaded to fork as a development checkpoint. Clicked pull request on autopilot. Work up to this point is incomplete.

@alzimmermsft
Copy link
Member

This fixes #4512

@alzimmermsft
Copy link
Member

/azp run java - storage - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@xiafu-msft
Copy link

Based on the discussion offline, we want to add tests for rehydrate priority

gapra-msft
gapra-msft approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few clean up comments, and I know youre working on adding rehydrate tests.

@jaschrep-msft jaschrep-msft merged commit 2052811 into Azure:master Sep 9, 2019
@jaschrep-msft jaschrep-msft deleted the rehydrate-priority branch August 3, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@xiafu-msft xiafu-msft Awaiting requested review from xiafu-msft

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

@sima-zhu sima-zhu Awaiting requested review from sima-zhu

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaschrep-msft @alzimmermsft @xiafu-msft @gapra-msft