Update Storage swagger #4981
Update Storage swagger #4981
Conversation
There are no (meaningful) code changes except the attribute in BlobHierarchyListSegment that I can't trace to the swagger
Note that additional work will have to be done to patch our higher level code to pass new parameters to existing APIs
tg-msft
requested review from
jianghaolu,
rickle-msft,
jaschrep-msft and
alzimmermsft
tg-msft
requested review from
danieljurek,
mitchdenny,
sima-zhu and
weshaggard
as code owners
...azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobHierarchyListSegment.java
Outdated
Show resolved
Hide resolved
|
I created an issue for missing error constant in StorageErrorCode. The issue only exists in Storage queue. Could you please take a look? It might something wrong with the service or missing the error code in swagger. |
| ``` yaml | ||
| directive: | ||
| - from: swagger-document | ||
| where: $["x-ms-paths"]["/{containerName}/{blob}?comp=copy&sync"] |
There was a problem hiding this comment.
Can't this be combined with the comp=copy version directly above this?
There was a problem hiding this comment.
I'm not aware of a way to do that.
There was a problem hiding this comment.
I thought the where clauses were json path syntax and if so I'd expect something like /{containerName}/{blob}?comp=copy* to work. Although I'm no expert in json path or these autorest directives so perhaps that is just wishful thinking.
There was a problem hiding this comment.
Maybe? The only documentation I've found doesn't mention that explicitly, but it does look like JSON Path syntax. I don't think you can use a wildcard * inside a string like that, but there's probably a way using those arcane JSON Path filter expressions. I don't want to block progress on getting this work done though so we can explore that after this PR.
|
Nice, these changes look great. @rickle-msft -- mind taking a look at Alan's commits in particular to CR the way he's changing the clients to call the new 2019-02-02 protocol layer? |
|
#5001 Calls out the changes that new features around Content-MD5 and x-ms-content-crc64 need to be handled as well as other potential changes that need to be handled. |
|
/azp run Azure.azure-sdk-for-java-mgmt (Build Java 7) |
|
No pipelines are associated with this pull request. |
|
/azp run Azure.azure-sdk-for-java-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Move Storage to official swagger files There are no (meaningful) code changes except the attribute in BlobHierarchyListSegment that I can't trace to the swagger * Upgrade blobs swagger to 2019-02-02 Note that additional work will have to be done to patch our higher level code to pass new parameters to existing APIs * Fixes to Swagger generation and updating to use new protocol layer * Fixed appendBlock content-type, added SpotBug exclusions for autogen code * Update README.md * Fixed incorrect exclude
* Move Storage to official swagger files There are no (meaningful) code changes except the attribute in BlobHierarchyListSegment that I can't trace to the swagger * Upgrade blobs swagger to 2019-02-02 Note that additional work will have to be done to patch our higher level code to pass new parameters to existing APIs * Fixes to Swagger generation and updating to use new protocol layer * Fixed appendBlock content-type, added SpotBug exclusions for autogen code * Update README.md * Fixed incorrect exclude
* Move Storage to official swagger files There are no (meaningful) code changes except the attribute in BlobHierarchyListSegment that I can't trace to the swagger * Upgrade blobs swagger to 2019-02-02 Note that additional work will have to be done to patch our higher level code to pass new parameters to existing APIs * Fixes to Swagger generation and updating to use new protocol layer * Fixed appendBlock content-type, added SpotBug exclusions for autogen code * Update README.md * Fixed incorrect exclude
There are two commits in this PR that might be easier to review individually.
The first changes to the official versions of the Storage swagger and adds README.md transformations address any deltas. I've regenerated and there was only one code change I couldn't trace back to the swagger which I'll call out below.
The second commit updates blobs to support STG69 features. This will require the feature crew to take over this PR and update any calls to the protocol layer that added additional parameters (I assume null will be fine to get started).