-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Identity libraries to new linting format #42833
Merged
alzimmermsft
merged 6 commits into
Azure:main
from
alzimmermsft:AzIdentity_MigrateToNewLintingSuppressions
Nov 13, 2024
Merged
Migrate Identity libraries to new linting format #42833
alzimmermsft
merged 6 commits into
Azure:main
from
alzimmermsft:AzIdentity_MigrateToNewLintingSuppressions
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
mssfang,
JonathanGiles,
srnagar,
rujche,
Netyyyy,
saragluna,
moarychan,
hallipr,
weshaggard,
benbp,
JimSuplizio,
g2vinay,
billwert,
joshfree and
a team
as code owners
November 6, 2024 13:20
alzimmermsft
requested review from
maorleger,
ahsonkhan,
mpodwysocki and
minhanh-phan
November 6, 2024 13:20
github-actions
bot
added
azure-spring
All azure-spring related issues
Azure.Identity
labels
Nov 6, 2024
API change check API changes are not detected in this pull request. |
billwert
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for Identity changes.
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Nov 14, 2024
Migrate Identity libraries to new linting format
billwert
pushed a commit
that referenced
this pull request
Nov 15, 2024
Migrate Identity libraries to new linting format
billwert
pushed a commit
that referenced
this pull request
Nov 15, 2024
Migrate Identity libraries to new linting format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Identity libraries to the new linting format where each library defines their own Checkstyle and Spotbugs suppressions, rather than relying on the global suppressions which are both less direct for each library and can result in inadvertent suppression.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines