Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Identity libraries to new linting format #42833

Conversation

alzimmermsft
Copy link
Member

Description

Migrates the Identity libraries to the new linting format where each library defines their own Checkstyle and Spotbugs suppressions, rather than relying on the global suppressions which are both less direct for each library and can result in inadvertent suppression.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for Identity changes.

@alzimmermsft alzimmermsft merged commit 843c8ef into Azure:main Nov 13, 2024
37 checks passed
@alzimmermsft alzimmermsft deleted the AzIdentity_MigrateToNewLintingSuppressions branch November 13, 2024 22:16
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this pull request Nov 14, 2024
Migrate Identity libraries to new linting format
billwert pushed a commit that referenced this pull request Nov 15, 2024
Migrate Identity libraries to new linting format
billwert pushed a commit that referenced this pull request Nov 15, 2024
Migrate Identity libraries to new linting format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity azure-spring All azure-spring related issues
Projects
Development

Successfully merging this pull request may close these issues.

3 participants