Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Identity Live tests deployment to Fed Auth. #42635

Merged
merged 34 commits into from
Dec 2, 2024
Merged

Migrate Identity Live tests deployment to Fed Auth. #42635

merged 34 commits into from
Dec 2, 2024

Conversation

g2vinay
Copy link
Member

@g2vinay g2vinay commented Oct 28, 2024 •
edited
Loading

Migrates Tests to TME sub and use fed auth for deployment.
Adds retry extension to minimize transient failures of live tests.

@g2vinay g2vinay changed the title update federated auth config Migrate Identity Live tests deployment to Fed Auth. Oct 28, 2024
@g2vinay g2vinay requested a review from weshaggard October 28, 2024 15:59
@g2vinay g2vinay force-pushed the update-identity-live-tests branch from c8f73e7 to 3cd1232 Compare October 28, 2024 16:21
weshaggard
weshaggard reviewed Oct 28, 2024
View reviewed changes
sdk/identity/ci.yml Outdated Show resolved Hide resolved
weshaggard
weshaggard reviewed Oct 28, 2024
View reviewed changes
sdk/identity/ci.yml Outdated Show resolved Hide resolved
benbp
benbp approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weshaggard
weshaggard reviewed Nov 4, 2024
View reviewed changes
sdk/identity/ci.yml Outdated Show resolved Hide resolved
@g2vinay g2vinay requested review from billwert, joshfree and a team as code owners November 25, 2024 20:20
weshaggard
weshaggard approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably some follow-ups needed but this gets us moved over to federated auth so I'm fine with it going it as is.

billwert
billwert requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also as discussed offline please test the new-testresources.ps1 -userauth flow with these changes.

@g2vinay
Copy link
Member Author

g2vinay commented Dec 2, 2024

also as discussed offline please test the new-testresources.ps1 -userauth flow with these changes.

This is being handled in separate PR.

#43150

@g2vinay g2vinay merged commit 27c677c into Azure:main Dec 2, 2024
35 checks passed
@benbp
Copy link
Member

benbp commented Dec 2, 2024

also as discussed offline please test the new-testresources.ps1 -userauth flow with these changes.

FYI -UserAuth is now the default and the parameter has been removed.

@billwert
Copy link
Contributor

billwert commented Dec 2, 2024

FYI -UserAuth is now the default and the parameter has been removed.

Oh, good context! @g2vinay meta point about testing the scenario stands tho. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard weshaggard approved these changes

@billwert billwert billwert approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@g2vinay @azure-sdk @benbp @billwert @weshaggard